Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Use makeStyles from core in layout examples #15845

Conversation

divyanshutomar
Copy link
Contributor

This fixes the theme import bug introduced due to a typo while importing Dashboard example from Page Layout Examples into another project.

Fixes #15834

@mui-pr-bot
Copy link

mui-pr-bot commented May 25, 2019

No bundle size changes comparing 35c9b8b...d8ee263

Generated by 🚫 dangerJS against d8ee263

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look at the other layout examples and see if they import from the core/styles or styles? We should prefer core/styles.

@eps1lon eps1lon changed the title [Docs] update makeStyles import in page-layout-exmaples/dashboard/orders [docs] Use makeStyles from core in layout examples May 25, 2019
@eps1lon eps1lon added the docs Improvements or additions to the documentation label May 25, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented May 25, 2019

The following files need to be changed:

  • /docs/src/pages/premium-themes/tweeper/pages/tweeper/Profile.js
  • /docs/src/pages/premium-themes/tweeper/components/tweeper/Tweet.js
  • /docs/src/pages/premium-themes/instapaper/pages/instapaper/Profile.js
  • /docs/src/pages/getting-started/page-layout-examples/dashboard/Deposits.js
  • /docs/src/pages/components/typography/Types.tsx
  • /docs/src/pages/components/selects/CustomizedSelects.tsx

@oliviertassinari oliviertassinari force-pushed the docs/page-layout-examples-dashboard-theme-fix branch from 787ee62 to 58e21f9 Compare May 25, 2019 11:14
@oliviertassinari oliviertassinari force-pushed the docs/page-layout-examples-dashboard-theme-fix branch from 58e21f9 to d8ee263 Compare May 25, 2019 11:30
@oliviertassinari oliviertassinari merged commit d711601 into mui:master May 25, 2019
@oliviertassinari
Copy link
Member

@divyanshutomar Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard Layout Example : theme.spacing is not a function
4 participants