[core] Prepare focus visible polyfill in ref phase #15851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the the setup of the focus-visible polyfill from the passive? side-effect phase into the ref phase. This has some benefits:
However this means that setup of the event listeners is now synchronously. Once the scheduler is stable we should schedule this with a user input priority.
Closes #15598 (actually),
Closes #15842
Edit:
Another drawback: In case a function component is passed to to
component
prop the focus-visible polyfill won't work. It will trigger warnings but no more errors. An error would be preferable but I don't think there is a deterministic way to check if the ref was attached to a proper component.