Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[styles] Fix Symbol() usage in IE11 #15856

Merged
merged 7 commits into from
May 26, 2019
Merged

[styles] Fix Symbol() usage in IE11 #15856

merged 7 commits into from
May 26, 2019

Conversation

aditya1906
Copy link
Contributor

Fixes #15833

package.json Outdated Show resolved Hide resolved
@mui-pr-bot
Copy link

mui-pr-bot commented May 25, 2019

Details of bundle changes.

Comparing: c48ee61...d4b1463

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.02% 🔺 +0.02% 🔺 315,678 315,731 86,445 86,462
@material-ui/core/Paper +0.08% 🔺 +0.12% 🔺 67,870 67,923 20,158 20,182
@material-ui/core/Paper.esm +0.09% 🔺 +0.11% 🔺 61,152 61,205 18,948 18,969
@material-ui/core/Popper 0.00% 0.00% 28,740 28,740 10,346 10,346
@material-ui/core/Textarea 0.00% 0.00% 5,513 5,513 2,376 2,376
@material-ui/core/TrapFocus 0.00% 0.00% 3,744 3,744 1,575 1,575
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,960 15,960 5,781 5,781
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 975 975
@material-ui/lab +0.04% 🔺 +0.04% 🔺 138,808 138,861 42,625 42,642
@material-ui/styles +0.10% 🔺 +0.15% 🔺 51,353 51,406 15,176 15,199
@material-ui/system 0.00% 0.00% 14,458 14,458 4,181 4,181
Button +0.06% 🔺 +0.06% 🔺 83,816 83,869 25,443 25,459
Modal 0.00% 0.00% 20,344 20,344 6,681 6,681
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 55,991 55,991 14,061 14,061
docs.main +0.03% 🔺 +0.04% 🔺 645,071 645,243 202,900 202,990
packages/material-ui/build/umd/material-ui.production.min.js +0.02% 🔺 +0.03% 🔺 294,598 294,651 83,939 83,964

Generated by 🚫 dangerJS against d4b1463

@oliviertassinari oliviertassinari changed the title [package.json] Add babel-polyfill to define Symbol() in IE11 [styles] Fix Symbol() usage in IE11 May 25, 2019
@oliviertassinari oliviertassinari requested a review from eps1lon May 25, 2019 19:49
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label May 25, 2019
Co-Authored-By: Sebastian Silbermann <[email protected]>
@aditya1906
Copy link
Contributor Author

I have updated the changes. Can it be merged now to the master branch?

@oliviertassinari
Copy link
Member

@aditya1906 Well done, contributing to OSS is easy :).

@aditya1906
Copy link
Contributor Author

Thank you @oliviertassinari and @eps1lon . And definitely learning a lot from Open Source Projects(and contribute to it) like material-ui. Thank you so much for your guidance, I highly appreciate it.
And I'm definitely looking forward to contribute more and more to your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Symbol' is undefined in IE11
4 participants