[IconButton] Add disable ripple props #15864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: c48ee61...1ab78a1
|
eps1lon
reviewed
May 26, 2019
| label?: React.ReactNode; | ||
| onChange?: (event: React.ChangeEvent<{ checked: boolean }>, value: any) => void; | ||
| onClick?: React.EventHandler<any>; | ||
| selected?: boolean; | ||
| style?: React.CSSProperties; | ||
| textColor?: string | 'secondary' | 'primary' | 'inherit'; | ||
| value?: any; |
There was a problem hiding this comment.
Is this necessary for the ripple?
There was a problem hiding this comment.
It was just moved down (sorted alphabetically), it's the value prop the Tab had before.
oliviertassinari
changed the title
| @@ -37,6 +37,26 @@ describe('<Tab />', () => { | |||
| skip: ['componentProp'], | |||
| })); | |||
|
|
|||
| it('should have a ripple by default', () => { | |||
| const wrapper = shallow(<Tab />); | |||
There was a problem hiding this comment.
We are moving away from shallow tests. Can we use the mount API?
oliviertassinari
approved these changes
May 26, 2019
oliviertassinari
added
component: icon button
|
@lychyi Much appreciated. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15858
Also adds the same missing props to the
Tabcomponent