Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styles] Make StyleRules backwards compatible #16200

Merged
merged 4 commits into from
Jun 17, 2019
Merged

[styles] Make StyleRules backwards compatible #16200

merged 4 commits into from
Jun 17, 2019

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jun 13, 2019 •
edited
Loading

  • Move some types out to @material-ui/types
  • If props is an empty interface default types to CSSProperties
  • Add typescript version of customization/components/DynamicInlineStyle

Blocked by #16199

Closes #16198

@merceyz merceyz changed the title [styles] Make CreateCSSProperties backwards compatible [styles] Make StyleRules backwards compatible Jun 13, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 13, 2019 •
edited
Loading

No bundle size changes comparing 4909bd8...b7ca06c

Generated by 🚫 dangerJS against b7ca06c

@merceyz merceyz marked this pull request as ready for review June 17, 2019 11:19
@eps1lon eps1lon self-requested a review June 17, 2019 11:45
@eps1lon eps1lon added the package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. label Jun 17, 2019
@eps1lon eps1lon merged commit c0e4103 into mui:master Jun 17, 2019
@eps1lon
Copy link
Member

eps1lon commented Jun 17, 2019

@merceyz Thanks!

@merceyz merceyz deleted the createStyles branch June 17, 2019 12:22
@eps1lon eps1lon mentioned this pull request Jun 22, 2019
Closed
@merceyz merceyz mentioned this pull request Jan 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CreateCSSProperties is not assignable to CSSProperties after upgrading to 4.0.2
4 participants
@merceyz @mui-pr-bot @eps1lon @oliviertassinari