[ci] Use sinon browser build #16208
Merged
[ci] Use sinon browser build #16208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 313e3e7...2d9c753 |
|
18s bundle time on this branch. Builds without this change vary between 36s and 60s. |
merceyz
reviewed
Jun 13, 2019
Co-Authored-By: Kristoffer K. <[email protected]>
|
Looks like a +20s boost, awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use webpack alias instead of transpiling the full sinon build. Bundling time went down to 26s from 62s locally. CI only takes 36s so we'll see how much faster that is. Should be at least 10s.