Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styles] Remove withTheme type from makeStyles options #16217

Merged
merged 1 commit into from
Jun 14, 2019
Merged

[styles] Remove withTheme type from makeStyles options #16217

merged 1 commit into from
Jun 14, 2019

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jun 13, 2019

  • Removed the withTheme option from makeStyles

Closes #16201

@mui-pr-bot
Copy link

No bundle size changes comparing a52834b...aca9595

Generated by 🚫 dangerJS against aca9595

@oliviertassinari oliviertassinari added package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. PR: good for merge labels Jun 14, 2019
@eps1lon eps1lon merged commit 4a3297d into mui:master Jun 14, 2019
@merceyz merceyz deleted the styles/make-styles branch June 14, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] makeStyles(styles, [options]) has strange option
4 participants
@merceyz @mui-pr-bot @oliviertassinari @eps1lon