[docs] Include and explain value type change in migration guide #16226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 564aed3...ad0bfc7 |
mbrookes
requested changes
Jun 14, 2019
|
|
||
| However, that type cannot be verified at compile time in situations where it depends | ||
| on the components children e.g. for `Select` or `RadioGroup`. This means that | ||
| the soundest option is to type it as `unknown` and let the developer decide |
There was a problem hiding this comment.
Should we do the same for the Slider?
https://github.com/mui-org/material-ui/blob/e499a0e93f04628724332d42c8156232786cc569/docs/src/pages/components/slider/ContinuousSlider.tsx#L19
There was a problem hiding this comment.
I'll take a look but I don't think so. As long as the type only depends on the props of a single components is fine. It's only problematic if the type is passed to children/parents because typescript can't check those relationships.
oliviertassinari
approved these changes
Jun 15, 2019
Co-Authored-By: Matt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16065