-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Batch of fixes #16229
[docs] Batch of fixes #16229
Conversation
Details of bundle changes.Comparing: 627da22...64bde33
|
Co-Authored-By: Aditya Shankar <[email protected]>
67dc7c1
to
247c07d
Compare
Updated. I also had to change the status code from 307 to 302 to make it work. e.g: https://material-ui.com/r/caveat-with-refs-guide KO
Co-Authored-By: Josh Wooding <[email protected]>
@oliviertassinari I noticed you removed all 3.x version documentation under v3 in documentation. and I assume it is 3.9.2 which was the last 3.x version. Is this means all releases prior to 3.9.2 are no longer supported? In many companies like ours, upgrading a package major like material-ui is not that quick and easy thing to do. we were at 3.8. Now I see that entire documentation is gone that it will be really difficult for us to find out components supported in that version and their props etc without diving in material-ui source. wouldn't that be better to keep those in a separate place like an archive and announce when they will be removed so people who are using it will be aware at x date it will no longer be supported. |
@SerdarSanri is your team able to use https://v3.material-ui.com/? This documents v3.9.3. |
@oliviertassinari We haven't upgraded to 3.9.2 yet. At least it is in our pipeline. I should have download documentation for 3.8. But because I don't have a reference what is different in between 3.8 and 3.9 it may cause issues. We may use components/props doesn't exist yet at 3.8 but introduced after. |
I can imagine, we don't document the version the new APIs have been introduced. I have removed the subdomains of older documentation versions as the builtin search was broken, making it hard to use. The new strategy should prevent this problem with the v4.x versions when we release v5.
If that's the case, you will need to upgrade to use it right? The upgrade between v3.8 and v3.9.3 should be straightforward. I would encourage this approach. Let's wait and see if we get more request for this. |
would that be possible to at least provide compressed documentation to download. So we can download and deploy locally. |
@SerdarSanri Sure, you can clone the repository, checkout the version, run yarn, run |
spinner
search query (73d4370)curl -I https://material-ui.com/r/styles-instance-warning
returns a 404. It should be fixed (395cf03)