Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Use @eps1lon/babel-plugin-optimize-react #16860

Closed

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Aug 2, 2019

Alternate to #16072 using facebook/create-react-app#7465 and custom patch (requires bigger refactoring otherwise).

@eps1lon eps1lon changed the title Feat/babel plugin optimize react fork [core] Use babel-plugin-optimize-react Aug 2, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 2, 2019

@material-ui/core: parsed: -0.85% 😍, gzip: +0.44%
@material-ui/lab: parsed: -0.75% 😍, gzip: -0.12% 😍

Details of bundle changes.

Comparing: e3144c5...8c6bb63

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.85% +0.44% 🔺 329,629 326,818 90,119 90,516
@material-ui/core/Paper -0.01% +0.12% 🔺 68,673 68,667 20,470 20,495
@material-ui/core/Paper.esm +0.02% 🔺 +0.08% 🔺 62,058 62,070 19,209 19,225
@material-ui/core/Popper -2.50% -2.39% 29,185 28,456 10,434 10,185
@material-ui/core/Textarea -12.15% -9.92% 5,759 5,059 2,368 2,133
@material-ui/core/TrapFocus -0.74% +0.06% 🔺 3,806 3,778 1,608 1,609
@material-ui/core/styles/createMuiTheme -0.02% +0.03% 🔺 16,389 16,386 5,824 5,826
@material-ui/core/useMediaQuery -20.86% -19.36% 3,221 2,549 1,312 1,058
@material-ui/lab -0.75% -0.12% 152,777 151,625 46,542 46,486
@material-ui/styles -0.02% +0.17% 🔺 51,390 51,380 15,286 15,312
@material-ui/system -0.05% +0.21% 🔺 15,753 15,745 4,380 4,389
Button -1.00% -0.82% 79,426 78,628 24,280 24,082
Modal -5.14% -4.02% 14,963 14,194 5,218 5,008
Portal -18.78% -15.88% 3,579 2,907 1,568 1,319
Rating -1.25% -0.77% 70,735 69,850 22,079 21,908
Slider -1.16% -0.91% 75,071 74,201 23,272 23,060
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 52,044 52,044 13,816 13,816
docs.main 0.00% +0.01% 🔺 590,571 590,585 188,751 188,763
packages/material-ui/build/umd/material-ui.production.min.js -0.55% +1.00% 🔺 299,715 298,052 86,127 86,988

Generated by 🚫 dangerJS against 8c6bb63

@eps1lon
Copy link
Member Author

eps1lon commented Aug 2, 2019

Fork not applied at the moment. Figuring out why.

@eps1lon eps1lon changed the title [core] Use babel-plugin-optimize-react [core] Use @eps1lon/babel-plugin-optimize-react Aug 2, 2019
@eps1lon eps1lon force-pushed the feat/babel-plugin-optimize-react-fork branch from 8494fe1 to 98b74d7 Compare August 2, 2019 12:34
@oliviertassinari
Copy link
Member

Did you figure out why the fork is not applied?

@oliviertassinari
Copy link
Member

I'm closing, it might not move forward anytime soon. I think that we should revisit it in the future, it has potential 🚀.

@eps1lon eps1lon deleted the feat/babel-plugin-optimize-react-fork branch September 3, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants