-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch small changes #16864
Batch small changes #16864
Conversation
@@ -11,7 +13,7 @@ import Tooltip from '@material-ui/core/Tooltip'; | |||
import NoSsr from '@material-ui/core/NoSsr'; | |||
import CssBaseline from '@material-ui/core/CssBaseline'; | |||
import MenuIcon from '@material-ui/icons/Menu'; | |||
import LanguageIcon from '@material-ui/icons/Language'; | |||
import LanguageIcon from '@material-ui/icons/Translate'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the same icon as React https://reactjs.org/
14cef2d
to
15181b8
Compare
@@ -39,6 +39,7 @@ | |||
"@types/react-window": "^1.7.0", | |||
"@types/styled-components": "4.1.12", | |||
"@zeit/next-typescript": "^1.1.1", | |||
"accept-language": "^3.0.18", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbrookes Your language negotiation logic is back :)
Details of bundle changes.Comparing: de0c2fd...d33faab
|
e61c197
to
08fb9c1
Compare
I don't agree with moving the customisation demos to the top, and I don't think that google search ranking should dictate the docs order. They used to follow a logical flow for someone reading or scanning from top to bottom - basic demo, more advanced demos (or variants), sizes, customisation. Now they are variously a bit of a hodge-podge, depending on how randomly they got rearranged. If someone's using google the search for component customisation, they won't care that it's at the bottom. Otherwise, 👍 to the rest of the PR. |
I'm sorry, I should have made it more clear. I haven't considered the google search ranking. I try to optimize for reducing the aggregated scroll depth. I'm trying to put the demos that trigger more code expand events closer to the top of the page. |
Does it change your point of view? I agree that the optimization of this metric should be balanced with the top-down logic of the content. It should still make sense. |
Okay, that makes more sense. I'm still not totally convinced about the reordering that was done some time ago, but live with it. Having the customisation at the top is just wrong though. For a new user visiting the component pages, they want to see and touch the native component implementation. Customisation should come later. It isn't that hard to find even if it is at the bottom. (Arguably if that were consistent, it makes it very easy!) |
e661b0b
to
1aabd7c
Compare
Fix the inconsistency, we had 18 occurences with the helper and 26 without.
1aabd7c
to
d33faab
Compare
I have changed the order, I think that I have found a more logical place for the demo :) |
👌 |
Let me know if there are any of the commits that you would want to see as an independent one. I have done them all in a single row: