[Stepper] Improve the description of the icon prop #16916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing ba2b44c...ac16cb0 |
oliviertassinari
approved these changes
Aug 6, 2019
mbrookes
force-pushed
the
stepper-icon-prop-wording
branch
from
4144550 to
ac16cb0
Compare
joshwooding
approved these changes
Aug 6, 2019
mbrookes
added
the
component: stepper
oliviertassinari
added
docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment here #12262 made me realize the wording of the icon prop descriptions could be improved. Feel free to suggest better alternatives.
Arguably the prop name is misleading, but that's a breaking change for another day. (Does it warrant a placeholder issue? I suspect stepper is not a particularly widely used component.)