Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add a customization example with ToggleButton #17401

Merged
merged 5 commits into from
Sep 14, 2019
Merged

[docs] Add a customization example with ToggleButton #17401

merged 5 commits into from
Sep 14, 2019

Conversation

nrkroeker
Copy link
Contributor

@nrkroeker nrkroeker commented Sep 11, 2019

Adds an example on the dividers component page to show vertical orientation, pretty straightforward 😄

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 11, 2019

No bundle size changes comparing 6a65aa7...da55e69

Generated by 🚫 dangerJS against da55e69

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Sep 12, 2019
@mbrookes
Copy link
Member

mbrookes commented Sep 12, 2019

@nrkroeker Thanks for working on this. What do you think about making it a ToggleButton customisation example instead? It might be a bit much for a simple vertical divider demo.

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 12, 2019

@mbrookes I was about to suggest making it a Toggle button customization demo 👍 (unless you really meant button group?)

@mbrookes
Copy link
Member

Yeah, ToggleButtons sorry, corrected.

@oliviertassinari oliviertassinari added the component: toggle button This is the name of the generic UI component, not the React module! label Sep 12, 2019
@oliviertassinari oliviertassinari changed the title [docs] Add demo for vertical divider [docs] Add a customization example with ToggleButton Sep 13, 2019
@oliviertassinari
Copy link
Member

@nrkroeker Thank you

@nrkroeker
Copy link
Contributor Author

@oliviertassinari Sorry I didn't end up having time to wrap that up, thank you for taking care of it! I've put together a stripped down version of this example that might be more suited to the divider demo but I can make a new PR for that.

@oliviertassinari
Copy link
Member

@nrkroeker No problem :)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: toggle button This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants