Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Fix opening select requiring double enter with NVDA #17773

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Oct 7, 2019

Closes #11833

Only observable using nvda (using 2019.2.1). You had to enter twice to be able to have full keyboard access to the listbox.

Affected pages:

role="document" was probably only used to silence the lint warning (handlers need a role).

To be tested:

  • can't remove document role since this is the node being focused. Once we get better focus managment primitives we can revamp the a11y of the dialog

    -- [Dialog] Test with testing-library #16780
    Edit: It doesn't help the current state anyway. This change is fine. The dialog a11y story can be improved separately.

@eps1lon eps1lon added accessibility a11y component: select This is the name of the generic UI component, not the React module! labels Oct 7, 2019
@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: 4aea24a...3f8fe91

bundle Size Change Size Gzip Change Gzip
LinearProgress -- 65.3 kB -- 20.3 kB
@material-ui/core[umd] ▼ -46 B (-0.02% ) 306 kB ▼ -17 B (-0.02% ) 88 kB
Link -- 66.6 kB -- 21 kB
@material-ui/core ▼ -46 B (-0.01% ) 347 kB ▼ -21 B (-0.02% ) 94.9 kB
@material-ui/lab -- 144 kB -- 45 kB
@material-ui/styles -- 51.8 kB -- 15.6 kB
@material-ui/system -- 15.7 kB -- 4.35 kB
AppBar -- 63.9 kB -- 19.9 kB
Avatar -- 62.7 kB -- 19.6 kB
Backdrop -- 67.7 kB -- 20.9 kB
Badge -- 65.3 kB -- 20.2 kB
BottomNavigation -- 62.4 kB -- 19.5 kB
BottomNavigationAction -- 75.3 kB -- 23.7 kB
Box -- 70.8 kB -- 21.3 kB
Breadcrumbs -- 68 kB -- 21.3 kB
Button -- 79.2 kB -- 24.5 kB
ButtonBase -- 73.8 kB -- 23.1 kB
ButtonGroup -- 64.2 kB -- 20 kB
Card -- 62.9 kB -- 19.6 kB
CardActionArea -- 74.9 kB -- 23.6 kB
CardActions -- 62 kB -- 19.3 kB
CardContent -- 62 kB -- 19.3 kB
CardHeader -- 65.1 kB -- 20.4 kB
CardMedia -- 62.4 kB -- 19.5 kB
Checkbox -- 81.6 kB -- 25.6 kB
Chip -- 70.6 kB -- 21.8 kB
CircularProgress -- 64.1 kB -- 20.1 kB
ClickAwayListener -- 3.85 kB -- 1.55 kB
Collapse -- 67.8 kB -- 20.9 kB
colorManipulator -- 3.83 kB -- 1.52 kB
Container -- 63.1 kB -- 19.6 kB
CssBaseline -- 57.6 kB -- 18 kB
DialogActions -- 62.1 kB -- 19.4 kB
DialogContent -- 62.2 kB -- 19.4 kB
DialogContentText -- 64 kB -- 20 kB
DialogTitle -- 64.3 kB -- 20.1 kB
Divider -- 62.6 kB -- 19.6 kB
docs.landing -- 54.3 kB -- 14.3 kB
ExpansionPanel -- 71.1 kB -- 22.1 kB
ExpansionPanelActions -- 62.1 kB -- 19.4 kB
ExpansionPanelDetails -- 61.9 kB -- 19.3 kB
ExpansionPanelSummary -- 77.9 kB -- 24.5 kB
Fab -- 76.6 kB -- 23.8 kB
Fade -- 23.1 kB -- 8.03 kB
FilledInput -- 72.9 kB -- 22.6 kB
FormControl -- 64.3 kB -- 19.9 kB
FormControlLabel -- 65.5 kB -- 20.5 kB
FormGroup -- 62 kB -- 19.3 kB
FormHelperText -- 63.3 kB -- 19.7 kB
FormLabel -- 63.2 kB -- 19.5 kB
Grid -- 65.1 kB -- 20.3 kB
GridList -- 62.5 kB -- 19.5 kB
GridListTile -- 63.7 kB -- 19.9 kB
GridListTileBar -- 63.2 kB -- 19.7 kB
Grow -- 23.7 kB -- 8.15 kB
Hidden -- 66.1 kB -- 20.6 kB
Icon -- 62.8 kB -- 19.6 kB
IconButton -- 76 kB -- 23.6 kB
Input -- 72 kB -- 22.4 kB
InputAdornment -- 65.1 kB -- 20.4 kB
InputBase -- 70.2 kB -- 22 kB
InputLabel -- 65.1 kB -- 20.2 kB
List -- 62.4 kB -- 19.3 kB
ListItem -- 77 kB -- 24 kB
ListItemAvatar -- 62.1 kB -- 19.3 kB
ListItemIcon -- 62.2 kB -- 19.4 kB
ListItemSecondaryAction -- 62 kB -- 19.3 kB
ListItemText -- 65 kB -- 20.3 kB
ListSubheader -- 62.8 kB -- 19.6 kB
MenuItem -- 78 kB -- 24.3 kB
MenuList -- 66 kB -- 20.5 kB
MobileStepper -- 67.7 kB -- 21 kB
NativeSelect -- 76.4 kB -- 24 kB
NoSsr -- 2.19 kB -- 1.04 kB
OutlinedInput -- 73.5 kB -- 22.8 kB
Paper -- 62.4 kB -- 19.3 kB
Popper -- 28.3 kB -- 10.2 kB
Portal -- 2.87 kB -- 1.29 kB
Radio -- 82.5 kB -- 25.9 kB
RadioGroup -- 63.2 kB -- 19.7 kB
Rating -- 69.8 kB -- 22.2 kB
RootRef -- 4.43 kB -- 1.67 kB
Skeleton -- 62.5 kB -- 19.5 kB
Slide -- 25.1 kB -- 8.66 kB
Slider -- 74.9 kB -- 23.5 kB
Snackbar -- 77.1 kB -- 24 kB
SnackbarContent -- 65.8 kB -- 20.6 kB
SpeedDial -- 85.7 kB -- 26.9 kB
SpeedDialAction -- 115 kB -- 36.4 kB
SpeedDialIcon -- 64.6 kB -- 20.2 kB
Step -- 62.6 kB -- 19.5 kB
StepButton -- 82.1 kB -- 25.7 kB
StepConnector -- 62.7 kB -- 19.6 kB
StepContent -- 68.9 kB -- 21.4 kB
StepIcon -- 64.7 kB -- 20.1 kB
StepLabel -- 68.6 kB -- 21.4 kB
Stepper -- 64.9 kB -- 20.3 kB
styles/createMuiTheme -- 16.2 kB -- 5.78 kB
SvgIcon -- 63 kB -- 19.6 kB
Drawer ▼ -46 B (-0.05% ) 84.3 kB ▼ -16 B (-0.06% ) 26 kB
Menu ▼ -46 B (-0.05% ) 88.2 kB ▼ -16 B (-0.06% ) 27.6 kB
TableSortLabel -- 77.2 kB -- 24.4 kB
Modal ▼ -46 B (-0.32% ) 14.3 kB ▼ -16 B (-0.32% ) 4.96 kB
Select ▼ -46 B (-0.04% ) 113 kB ▼ -24 B (-0.07% ) 33.5 kB
TextField ▼ -46 B (-0.04% ) 121 kB ▼ -24 B (-0.07% ) 35.4 kB
Switch -- 80.8 kB -- 25.1 kB
Tab -- 76.2 kB -- 24.1 kB
Table -- 62.4 kB -- 19.4 kB
TableBody -- 62.1 kB -- 19.3 kB
TableCell -- 64.1 kB -- 20 kB
TableFooter -- 62.1 kB -- 19.3 kB
TableHead -- 62.1 kB -- 19.3 kB
TableRow -- 62.5 kB -- 19.5 kB
Tabs -- 85.3 kB -- 27.1 kB
TextareaAutosize -- 5.06 kB -- 2.11 kB
ToggleButton -- 76 kB -- 23.9 kB
ToggleButtonGroup -- 63.2 kB -- 19.8 kB
Toolbar -- 62.3 kB -- 19.4 kB
Tooltip -- 99 kB -- 31.3 kB
TreeItem -- 73.4 kB -- 23 kB
TreeView -- 66 kB -- 20.6 kB
Typography -- 63.6 kB -- 19.8 kB
useMediaQuery -- 2.49 kB -- 1.05 kB
SwipeableDrawer ▼ -46 B (-0.05% ) 90.7 kB ▼ -14 B (-0.05% ) 28 kB
docs.main ▼ -46 B (-0.01% ) 598 kB ▼ -12 B (-0.01% ) 191 kB
Dialog ▼ -46 B (-0.06% ) 82.5 kB ▼ -17 B (-0.07% ) 25.5 kB
TablePagination ▼ -46 B (-0.03% ) 139 kB ▼ -17 B (-0.04% ) 40.6 kB
Zoom -- 23.1 kB -- 8.04 kB
Popover ▼ -46 B (-0.06% ) 82.6 kB ▼ -15 B (-0.06% ) 25.4 kB

Generated by 🚫 dangerJS against 3f8fe91

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blind trust for this one 😁

@eps1lon eps1lon merged commit 285be27 into mui:master Oct 8, 2019
@eps1lon eps1lon deleted the fix/Select/keyboard-open-close branch October 8, 2019 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Select] Cannot interact with the component using the keyboard with NVDA opened
4 participants