Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Add missing 'clear' to onInputChange typing #19286

Merged
merged 1 commit into from
Jan 18, 2020
Merged

[Autocomplete] Add missing 'clear' to onInputChange typing #19286

merged 1 commit into from
Jan 18, 2020

Conversation

mvestergaard
Copy link
Contributor

@oliviertassinari oliviertassinari changed the title Add missing 'clear' reason to useAutocomplete.onInputChange typing [Autocomplete] Add missing 'clear' to onInputChange typing Jan 18, 2020
@oliviertassinari oliviertassinari added component: autocomplete This is the name of the generic UI component, not the React module! typescript labels Jan 18, 2020
@mvestergaard mvestergaard force-pushed the fix-autocomplete-typing branch from 8ad0cea to d6537c1 Compare January 18, 2020 20:42
@oliviertassinari oliviertassinari merged commit a0abfca into mui:master Jan 18, 2020
@oliviertassinari
Copy link
Member

@mvestergaard thanks

@mvestergaard mvestergaard deleted the fix-autocomplete-typing branch January 18, 2020 20:51
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 18, 2020 •
edited
Loading

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%

Details of bundle changes.

Comparing: 18dc9f7...d6537c1

bundle Size Change Size Gzip Change Gzip
docs.main ▲ +617 kB (+Infinity% ) 617 kB ▲ +196 kB (+Infinity% ) 196 kB
@material-ui/core ▲ +361 kB (+Infinity% ) 361 kB ▲ +98.7 kB (+Infinity% ) 98.7 kB
@material-ui/core[umd] ▲ +317 kB (+Infinity% ) 317 kB ▲ +91.9 kB (+Infinity% ) 91.9 kB
@material-ui/lab ▲ +185 kB (+Infinity% ) 185 kB ▲ +55.1 kB (+Infinity% ) 55.1 kB
TablePagination ▲ +143 kB (+Infinity% ) 143 kB ▲ +41.8 kB (+Infinity% ) 41.8 kB
Autocomplete ▲ +132 kB (+Infinity% ) 132 kB ▲ +41.3 kB (+Infinity% ) 41.3 kB
TextField ▲ +125 kB (+Infinity% ) 125 kB ▲ +36.5 kB (+Infinity% ) 36.5 kB
SpeedDialAction ▲ +118 kB (+Infinity% ) 118 kB ▲ +37.5 kB (+Infinity% ) 37.5 kB
Select ▲ +116 kB (+Infinity% ) 116 kB ▲ +34.4 kB (+Infinity% ) 34.4 kB
Tooltip ▲ +102 kB (+Infinity% ) 102 kB ▲ +32.3 kB (+Infinity% ) 32.3 kB
SwipeableDrawer ▲ +92.4 kB (+Infinity% ) 92.4 kB ▲ +28.9 kB (+Infinity% ) 28.9 kB
Menu ▲ +88.9 kB (+Infinity% ) 88.9 kB ▲ +27.4 kB (+Infinity% ) 27.4 kB
SpeedDial ▲ +86.4 kB (+Infinity% ) 86.4 kB ▲ +27.2 kB (+Infinity% ) 27.2 kB
Tabs ▲ +85.8 kB (+Infinity% ) 85.8 kB ▲ +27.2 kB (+Infinity% ) 27.2 kB
Drawer ▲ +85 kB (+Infinity% ) 85 kB ▲ +25.8 kB (+Infinity% ) 25.8 kB
Radio ▲ +84.3 kB (+Infinity% ) 84.3 kB ▲ +26.6 kB (+Infinity% ) 26.6 kB
Alert ▲ +83.9 kB (+Infinity% ) 83.9 kB ▲ +26.3 kB (+Infinity% ) 26.3 kB
ButtonGroup ▲ +83.4 kB (+Infinity% ) 83.4 kB ▲ +25.5 kB (+Infinity% ) 25.5 kB
Popover ▲ +83.3 kB (+Infinity% ) 83.3 kB ▲ +25.8 kB (+Infinity% ) 25.8 kB
Checkbox ▲ +83.2 kB (+Infinity% ) 83.2 kB ▲ +26.3 kB (+Infinity% ) 26.3 kB
Dialog ▲ +83.2 kB (+Infinity% ) 83.2 kB ▲ +25.9 kB (+Infinity% ) 25.9 kB
Chip ▲ +82.8 kB (+Infinity% ) 82.8 kB ▲ +25.4 kB (+Infinity% ) 25.4 kB
StepButton ▲ +82.5 kB (+Infinity% ) 82.5 kB ▲ +26.1 kB (+Infinity% ) 26.1 kB
Switch ▲ +82.4 kB (+Infinity% ) 82.4 kB ▲ +26 kB (+Infinity% ) 26 kB
Button ▲ +79.9 kB (+Infinity% ) 79.9 kB ▲ +24.5 kB (+Infinity% ) 24.5 kB
MenuItem ▲ +78.4 kB (+Infinity% ) 78.4 kB ▲ +24.5 kB (+Infinity% ) 24.5 kB
ExpansionPanelSummary ▲ +78.3 kB (+Infinity% ) 78.3 kB ▲ +24.7 kB (+Infinity% ) 24.7 kB
TableSortLabel ▲ +77.6 kB (+Infinity% ) 77.6 kB ▲ +24.4 kB (+Infinity% ) 24.4 kB
ListItem ▲ +77.3 kB (+Infinity% ) 77.3 kB ▲ +24.2 kB (+Infinity% ) 24.2 kB
NativeSelect ▲ +77 kB (+Infinity% ) 77 kB ▲ +24.3 kB (+Infinity% ) 24.3 kB
Fab ▲ +77 kB (+Infinity% ) 77 kB ▲ +24 kB (+Infinity% ) 24 kB
Slider ▲ +76.8 kB (+Infinity% ) 76.8 kB ▲ +24.3 kB (+Infinity% ) 24.3 kB
Tab ▲ +76.5 kB (+Infinity% ) 76.5 kB ▲ +24.2 kB (+Infinity% ) 24.2 kB
ToggleButton ▲ +76.3 kB (+Infinity% ) 76.3 kB ▲ +24.2 kB (+Infinity% ) 24.2 kB
IconButton ▲ +76.3 kB (+Infinity% ) 76.3 kB ▲ +23.8 kB (+Infinity% ) 23.8 kB
BottomNavigationAction ▲ +75.7 kB (+Infinity% ) 75.7 kB ▲ +23.9 kB (+Infinity% ) 23.9 kB
Snackbar ▲ +75.5 kB (+Infinity% ) 75.5 kB ▲ +23.6 kB (+Infinity% ) 23.6 kB
CardActionArea ▲ +75.3 kB (+Infinity% ) 75.3 kB ▲ +23.7 kB (+Infinity% ) 23.7 kB
ButtonBase ▲ +74.2 kB (+Infinity% ) 74.2 kB ▲ +23.3 kB (+Infinity% ) 23.3 kB
OutlinedInput ▲ +74.1 kB (+Infinity% ) 74.1 kB ▲ +23.1 kB (+Infinity% ) 23.1 kB
TreeItem ▲ +74.1 kB (+Infinity% ) 74.1 kB ▲ +23.5 kB (+Infinity% ) 23.5 kB
FilledInput ▲ +73.7 kB (+Infinity% ) 73.7 kB ▲ +22.9 kB (+Infinity% ) 22.9 kB
Input ▲ +72.6 kB (+Infinity% ) 72.6 kB ▲ +22.7 kB (+Infinity% ) 22.7 kB
ExpansionPanel ▲ +72.5 kB (+Infinity% ) 72.5 kB ▲ +22.7 kB (+Infinity% ) 22.7 kB
Box ▲ +71 kB (+Infinity% ) 71 kB ▲ +21.7 kB (+Infinity% ) 21.7 kB
InputBase ▲ +70.8 kB (+Infinity% ) 70.8 kB ▲ +22.2 kB (+Infinity% ) 22.2 kB
Rating ▲ +70.6 kB (+Infinity% ) 70.6 kB ▲ +22.7 kB (+Infinity% ) 22.7 kB
StepContent ▲ +69.3 kB (+Infinity% ) 69.3 kB ▲ +21.7 kB (+Infinity% ) 21.7 kB
StepLabel ▲ +68.7 kB (+Infinity% ) 68.7 kB ▲ +21.7 kB (+Infinity% ) 21.7 kB
Collapse ▲ +68.2 kB (+Infinity% ) 68.2 kB ▲ +21.1 kB (+Infinity% ) 21.1 kB
Backdrop ▲ +68 kB (+Infinity% ) 68 kB ▲ +21 kB (+Infinity% ) 21 kB
MobileStepper ▲ +68 kB (+Infinity% ) 68 kB ▲ +21.3 kB (+Infinity% ) 21.3 kB
Breadcrumbs ▲ +67.9 kB (+Infinity% ) 67.9 kB ▲ +21.3 kB (+Infinity% ) 21.3 kB
TreeView ▲ +66.8 kB (+Infinity% ) 66.8 kB ▲ +21 kB (+Infinity% ) 21 kB
Link ▲ +66.7 kB (+Infinity% ) 66.7 kB ▲ +21.1 kB (+Infinity% ) 21.1 kB
MenuList ▲ +66.2 kB (+Infinity% ) 66.2 kB ▲ +20.7 kB (+Infinity% ) 20.7 kB
Hidden ▲ +66.1 kB (+Infinity% ) 66.1 kB ▲ +20.7 kB (+Infinity% ) 20.7 kB
FormControlLabel ▲ +65.6 kB (+Infinity% ) 65.6 kB ▲ +20.6 kB (+Infinity% ) 20.6 kB
InputLabel ▲ +65.5 kB (+Infinity% ) 65.5 kB ▲ +20.2 kB (+Infinity% ) 20.2 kB
LinearProgress ▲ +65.4 kB (+Infinity% ) 65.4 kB ▲ +20.5 kB (+Infinity% ) 20.5 kB
Badge ▲ +65.4 kB (+Infinity% ) 65.4 kB ▲ +20.4 kB (+Infinity% ) 20.4 kB
Avatar ▲ +65.4 kB (+Infinity% ) 65.4 kB ▲ +20.6 kB (+Infinity% ) 20.6 kB
Grid ▲ +65.2 kB (+Infinity% ) 65.2 kB ▲ +20.4 kB (+Infinity% ) 20.4 kB
InputAdornment ▲ +65.2 kB (+Infinity% ) 65.2 kB ▲ +20.5 kB (+Infinity% ) 20.5 kB
CardHeader ▲ +65.2 kB (+Infinity% ) 65.2 kB ▲ +20.5 kB (+Infinity% ) 20.5 kB
ListItemText ▲ +65.1 kB (+Infinity% ) 65.1 kB ▲ +20.4 kB (+Infinity% ) 20.4 kB
Stepper ▲ +65 kB (+Infinity% ) 65 kB ▲ +20.5 kB (+Infinity% ) 20.5 kB
StepIcon ▲ +64.8 kB (+Infinity% ) 64.8 kB ▲ +20.2 kB (+Infinity% ) 20.2 kB
SpeedDialIcon ▲ +64.7 kB (+Infinity% ) 64.7 kB ▲ +20.3 kB (+Infinity% ) 20.3 kB
RadioGroup ▲ +64.6 kB (+Infinity% ) 64.6 kB ▲ +20 kB (+Infinity% ) 20 kB
FormControl ▲ +64.5 kB (+Infinity% ) 64.5 kB ▲ +20.1 kB (+Infinity% ) 20.1 kB
DialogTitle ▲ +64.4 kB (+Infinity% ) 64.4 kB ▲ +20.2 kB (+Infinity% ) 20.2 kB
AlertTitle ▲ +64.3 kB (+Infinity% ) 64.3 kB ▲ +20.2 kB (+Infinity% ) 20.2 kB
CircularProgress ▲ +64.2 kB (+Infinity% ) 64.2 kB ▲ +20.3 kB (+Infinity% ) 20.3 kB
DialogContentText ▲ +64.2 kB (+Infinity% ) 64.2 kB ▲ +20.2 kB (+Infinity% ) 20.2 kB
TableCell ▲ +64.2 kB (+Infinity% ) 64.2 kB ▲ +20.2 kB (+Infinity% ) 20.2 kB
AppBar ▲ +64.1 kB (+Infinity% ) 64.1 kB ▲ +20.1 kB (+Infinity% ) 20.1 kB
GridListTile ▲ +63.9 kB (+Infinity% ) 63.9 kB ▲ +20 kB (+Infinity% ) 20 kB
Typography ▲ +63.8 kB (+Infinity% ) 63.8 kB ▲ +20 kB (+Infinity% ) 20 kB
SnackbarContent ▲ +63.7 kB (+Infinity% ) 63.7 kB ▲ +20.1 kB (+Infinity% ) 20.1 kB
FormLabel ▲ +63.6 kB (+Infinity% ) 63.6 kB ▲ +19.7 kB (+Infinity% ) 19.7 kB
FormHelperText ▲ +63.5 kB (+Infinity% ) 63.5 kB ▲ +20 kB (+Infinity% ) 20 kB
Container ▲ +63.4 kB (+Infinity% ) 63.4 kB ▲ +19.8 kB (+Infinity% ) 19.8 kB
GridListTileBar ▲ +63.3 kB (+Infinity% ) 63.3 kB ▲ +19.9 kB (+Infinity% ) 19.9 kB
ToggleButtonGroup ▲ +63.3 kB (+Infinity% ) 63.3 kB ▲ +19.9 kB (+Infinity% ) 19.9 kB
SvgIcon ▲ +63.2 kB (+Infinity% ) 63.2 kB ▲ +19.8 kB (+Infinity% ) 19.8 kB
Skeleton ▲ +63 kB (+Infinity% ) 63 kB ▲ +19.9 kB (+Infinity% ) 19.9 kB
Card ▲ +63 kB (+Infinity% ) 63 kB ▲ +19.7 kB (+Infinity% ) 19.7 kB
Icon ▲ +62.9 kB (+Infinity% ) 62.9 kB ▲ +19.7 kB (+Infinity% ) 19.7 kB
ListSubheader ▲ +62.9 kB (+Infinity% ) 62.9 kB ▲ +19.8 kB (+Infinity% ) 19.8 kB
StepConnector ▲ +62.8 kB (+Infinity% ) 62.8 kB ▲ +19.8 kB (+Infinity% ) 19.8 kB
Step ▲ +62.8 kB (+Infinity% ) 62.8 kB ▲ +19.7 kB (+Infinity% ) 19.7 kB
Divider ▲ +62.7 kB (+Infinity% ) 62.7 kB ▲ +19.7 kB (+Infinity% ) 19.7 kB
Table ▲ +62.7 kB (+Infinity% ) 62.7 kB ▲ +19.7 kB (+Infinity% ) 19.7 kB
TableRow ▲ +62.6 kB (+Infinity% ) 62.6 kB ▲ +19.6 kB (+Infinity% ) 19.6 kB
GridList ▲ +62.6 kB (+Infinity% ) 62.6 kB ▲ +19.7 kB (+Infinity% ) 19.7 kB
BottomNavigation ▲ +62.5 kB (+Infinity% ) 62.5 kB ▲ +19.6 kB (+Infinity% ) 19.6 kB
Paper ▲ +62.5 kB (+Infinity% ) 62.5 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
List ▲ +62.5 kB (+Infinity% ) 62.5 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
CardMedia ▲ +62.5 kB (+Infinity% ) 62.5 kB ▲ +19.7 kB (+Infinity% ) 19.7 kB
Toolbar ▲ +62.5 kB (+Infinity% ) 62.5 kB ▲ +19.6 kB (+Infinity% ) 19.6 kB
AvatarGroup ▲ +62.4 kB (+Infinity% ) 62.4 kB ▲ +19.6 kB (+Infinity% ) 19.6 kB
DialogContent ▲ +62.3 kB (+Infinity% ) 62.3 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
ListItemIcon ▲ +62.3 kB (+Infinity% ) 62.3 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
ListItemAvatar ▲ +62.2 kB (+Infinity% ) 62.2 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
TableFooter ▲ +62.2 kB (+Infinity% ) 62.2 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
TableHead ▲ +62.2 kB (+Infinity% ) 62.2 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
TableBody ▲ +62.2 kB (+Infinity% ) 62.2 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
DialogActions ▲ +62.2 kB (+Infinity% ) 62.2 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
ExpansionPanelActions ▲ +62.2 kB (+Infinity% ) 62.2 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
CardActions ▲ +62.2 kB (+Infinity% ) 62.2 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
FormGroup ▲ +62.1 kB (+Infinity% ) 62.1 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
ListItemSecondaryAction ▲ +62.1 kB (+Infinity% ) 62.1 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
CardContent ▲ +62.1 kB (+Infinity% ) 62.1 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
TableContainer ▲ +62.1 kB (+Infinity% ) 62.1 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
ExpansionPanelDetails ▲ +62.1 kB (+Infinity% ) 62.1 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
CssBaseline ▲ +57.7 kB (+Infinity% ) 57.7 kB ▲ +18.1 kB (+Infinity% ) 18.1 kB
@material-ui/styles ▲ +51.2 kB (+Infinity% ) 51.2 kB ▲ +15.4 kB (+Infinity% ) 15.4 kB
docs.landing ▲ +51 kB (+Infinity% ) 51 kB ▲ +13.5 kB (+Infinity% ) 13.5 kB
Popper ▲ +28.8 kB (+Infinity% ) 28.8 kB ▲ +10.3 kB (+Infinity% ) 10.3 kB
Slide ▲ +25.6 kB (+Infinity% ) 25.6 kB ▲ +8.73 kB (+Infinity% ) 8.73 kB
Grow ▲ +24.2 kB (+Infinity% ) 24.2 kB ▲ +8.21 kB (+Infinity% ) 8.21 kB
Zoom ▲ +23.6 kB (+Infinity% ) 23.6 kB ▲ +8.12 kB (+Infinity% ) 8.12 kB
Fade ▲ +23.6 kB (+Infinity% ) 23.6 kB ▲ +8 kB (+Infinity% ) 8 kB
styles/createMuiTheme ▲ +16.6 kB (+Infinity% ) 16.6 kB ▲ +5.83 kB (+Infinity% ) 5.83 kB
@material-ui/system ▲ +14.8 kB (+Infinity% ) 14.8 kB ▲ +4.07 kB (+Infinity% ) 4.07 kB
Modal ▲ +14.5 kB (+Infinity% ) 14.5 kB ▲ +5.05 kB (+Infinity% ) 5.05 kB
useAutocomplete ▲ +14.5 kB (+Infinity% ) 14.5 kB ▲ +5.23 kB (+Infinity% ) 5.23 kB
TextareaAutosize ▲ +5.12 kB (+Infinity% ) 5.12 kB ▲ +2.14 kB (+Infinity% ) 2.14 kB
RootRef ▲ +4.24 kB (+Infinity% ) 4.24 kB ▲ +1.64 kB (+Infinity% ) 1.64 kB
ClickAwayListener ▲ +3.91 kB (+Infinity% ) 3.91 kB ▲ +1.55 kB (+Infinity% ) 1.55 kB
colorManipulator ▲ +3.88 kB (+Infinity% ) 3.88 kB ▲ +1.52 kB (+Infinity% ) 1.52 kB
Portal ▲ +2.92 kB (+Infinity% ) 2.92 kB ▲ +1.3 kB (+Infinity% ) 1.3 kB
useMediaQuery ▲ +2.51 kB (+Infinity% ) 2.51 kB ▲ +1.06 kB (+Infinity% ) 1.06 kB
NoSsr ▲ +2.19 kB (+Infinity% ) 2.19 kB ▲ +1.04 kB (+Infinity% ) 1.04 kB

Generated by 🚫 dangerJS against d6537c1

@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
This was referenced Feb 23, 2020
Open
Closed
Merged
This was referenced Mar 20, 2020
Merged
Merged
This was referenced Apr 6, 2020
Open
Closed
This was referenced Apr 16, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvestergaard @oliviertassinari @mui-pr-bot