[StepButton] Fix prop-types warning regarding expanded
#19332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
eps1lon
commented
Jan 21, 2020
| getAllByTestId('props').forEach(child => { | ||
| // HTMLElement.dataset is a DOMStringMap which fails deep.equal | ||
| const datasetAsObject = { ...child.dataset }; | ||
| expect(datasetAsObject).to.deep.equal({ |
There was a problem hiding this comment.
Using deep equality over (previous) subset checking. This helps exposing all props that children might receive.
|
|
||
| describe('event handlers', () => { | ||
| describe('handleMouseEnter/Leave', () => { |
There was a problem hiding this comment.
This handles the same as the "should bubble callbacks used internally" test whose description is misleading. It never tested bubbling as far as I can tell.
| assert.strictEqual(handleTouchStart.callCount, 2); | ||
| const button = getByRole('button'); | ||
|
|
||
| fireEvent.mouseOver(button); |
There was a problem hiding this comment.
Something about mouseenter vs mouseover. Need a refresher what the difference is and how react handles those.
Details of bundle changes.Comparing: 2082679...6b0fbb5
|
eps1lon
force-pushed
the
test/testing-lib-step
branch
from
bdb59b3 to
6b0fbb5
Compare
oliviertassinari
approved these changes
Jan 22, 2020
|
👌 |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Jan 23, 2020
This was referenced Mar 20, 2020
This was referenced Apr 6, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
when using
<Step><StepButton /></Step>which is used in our docs.Used this opportunity to convert Step and StepButton to testing-library where possible.
Includes a fix forTouchRipplethat will be handled in a different PR.