[core] Remove unecessary exports from styles/transitions.js #19337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
|
@material-ui/core: parsed: -0.12% 😍, gzip: -0.08% 😍 Details of bundle changes.Comparing: 7ced513...a5d2dfa
|
|
Hum, I wonder why we have tests for these helpers. Could you check the history? |
|
Wasn't able to follow them to their creation, it looks like these tests are pretty old, from before you migrated to the lerna |
|
The export originates from #6936. Ok, so the motivation was to increase test coverage. We can move forward :). It has only been recently exported by mistake. |
oliviertassinari
approved these changes
Jan 22, 2020
|
Thanks @oliviertassinari!! |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Jan 23, 2020
This was referenced Mar 20, 2020
This was referenced Apr 6, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some unused/untyped exports from
styles/transitions.js, in response to this Issue thread:Closes #19258