Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove unstable_StrictMode transition components #20952

Merged
merged 11 commits into from
May 9, 2020
Merged

[core] Remove unstable_StrictMode transition components #20952

merged 11 commits into from
May 9, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented May 8, 2020 •
edited
Loading

  • remvoves unstable_StrictMode* transition components
  • adds disableStrictModeCompat to Collapse, Fade, Grow, Zoom in case forwarding ref is not an option (Slide already had the necessary restrictions).
  • adds documentation for unstable_createMuiStrictModeTheme

@mui-pr-bot
Copy link

mui-pr-bot commented May 8, 2020 •
edited
Loading

@material-ui/core: parsed: -1.19% 😍, gzip: -0.77% 😍
@material-ui/lab: parsed: +0.76% , gzip: +0.97%

Details of bundle changes.

Comparing: 8c6fe14...dbf3d00

Details of page changes
bundle Size Change Size Gzip Change Gzip
/components/snackbars ▼ -900 B (-3.15% ) 27.7 kB -- -1 B
/customization/theming ▲ +800 B (+4.76% ) 17.6 kB -- -1 B
/components/transitions ▲ +600 B (+5.22% ) 12.1 kB -- -1 B
/components/tooltips ▲ +500 B (+3.03% ) 17 kB -- -1 B
/components/app-bar ▲ +200 B (+0.67% ) 30.2 kB -- -1 B
/components/floating-action-button ▲ +200 B (+1.92% ) 10.6 kB -- -1 B
/components/speed-dial ▲ +200 B (+1.39% ) 14.6 kB -- -1 B
/api-docs/collapse ▲ +110 B (+5.45% ) 2.13 kB -- -1 B
/api-docs/fade ▲ +110 B (+7.91% ) 1.5 kB -- -1 B
/api-docs/grow ▲ +110 B (+7.64% ) 1.55 kB -- -1 B
/api-docs/zoom ▲ +110 B (+7.80% ) 1.52 kB -- -1 B
/premium-themes/onepirate ▲ +50 B (+0.69% ) 7.32 kB -- -1 B
/blog/october-2019-update ▲ +10 B (+0.40% ) 2.51 kB -- -1 B
/components/pickers ▼ -10 B (-0.17% ) 6 kB -- -1 B
/_app -- 37 kB -- -1 B
/api-docs/alert-title -- 1.4 kB -- -1 B
/api-docs/alert -- 2.4 kB -- -1 B
/api-docs/app-bar -- 1.94 kB -- -1 B
/api-docs/autocomplete -- 4.61 kB -- -1 B
/api-docs/avatar-group -- 1.51 kB -- -1 B
/api-docs/avatar -- 1.86 kB -- -1 B
/api-docs/backdrop -- 1.72 kB -- -1 B
/api-docs/badge -- 2.13 kB -- -1 B
/api-docs/bottom-navigation-action -- 1.81 kB -- -1 B
/api-docs/bottom-navigation -- 1.7 kB -- -1 B
/api-docs/breadcrumbs -- 1.84 kB -- -1 B
/api-docs/button-base -- 2.33 kB -- -1 B
/api-docs/button-group -- 2.23 kB -- -1 B
/api-docs/button -- 2.56 kB -- -1 B
/api-docs/card-action-area -- 1.58 kB -- -1 B
/api-docs/card-actions -- 1.47 kB -- -1 B
/api-docs/card-content -- 1.45 kB -- -1 B
/api-docs/card-header -- 1.78 kB -- -1 B
/api-docs/card-media -- 1.69 kB -- -1 B
/api-docs/card -- 1.5 kB -- -1 B
/api-docs/checkbox -- 2.3 kB -- -1 B
/api-docs/chip -- 2.46 kB -- -1 B
/api-docs/circular-progress -- 2.07 kB -- -1 B
/api-docs/click-away-listener -- 1.37 kB -- -1 B
/api-docs/container -- 1.86 kB -- -1 B
/api-docs/css-baseline -- 1.4 kB -- -1 B
/api-docs/dialog-actions -- 1.47 kB -- -1 B
/api-docs/dialog-content-text -- 1.48 kB -- -1 B
/api-docs/dialog-content -- 1.45 kB -- -1 B
/api-docs/dialog-title -- 1.49 kB -- -1 B
/api-docs/dialog -- 2.73 kB -- -1 B
/api-docs/divider -- 1.81 kB -- -1 B
/api-docs/drawer -- 2.13 kB -- -1 B
/api-docs/expansion-panel-actions -- 1.49 kB -- -1 B
/api-docs/expansion-panel-details -- 1.41 kB -- -1 B
/api-docs/expansion-panel-summary -- 1.72 kB -- -1 B
/api-docs/expansion-panel -- 1.97 kB -- -1 B
/api-docs/fab -- 2.11 kB -- -1 B
/api-docs/filled-input -- 2.87 kB -- -1 B
/api-docs/form-control-label -- 1.98 kB -- -1 B
/api-docs/form-control -- 2.36 kB -- -1 B
/api-docs/form-group -- 1.55 kB -- -1 B
/api-docs/form-helper-text -- 1.91 kB -- -1 B
/api-docs/form-label -- 1.84 kB -- -1 B
/api-docs/grid-list-tile-bar -- 1.8 kB -- -1 B
/api-docs/grid-list-tile -- 1.72 kB -- -1 B
/api-docs/grid-list -- 1.62 kB -- -1 B
/api-docs/grid -- 2.56 kB -- -1 B
/api-docs/hidden -- 1.53 kB -- -1 B
/api-docs/icon-button -- 2.1 kB -- -1 B
/api-docs/icon -- 1.78 kB -- -1 B
/api-docs/input-adornment -- 1.93 kB -- -1 B
/api-docs/input-base -- 2.95 kB -- -1 B
/api-docs/input-label -- 2.07 kB -- -1 B
/api-docs/input -- 2.83 kB -- -1 B
/api-docs/linear-progress -- 2.03 kB -- -1 B
/api-docs/link -- 1.93 kB -- -1 B
/api-docs/list-item-avatar -- 1.5 kB -- -1 B
/api-docs/list-item-icon -- 1.51 kB -- -1 B
/api-docs/list-item-secondary-action -- 1.47 kB -- -1 B
/api-docs/list-item-text -- 1.79 kB -- -1 B
/api-docs/list-item -- 2.25 kB -- -1 B
/api-docs/list-subheader -- 1.77 kB -- -1 B
/api-docs/list -- 1.68 kB -- -1 B
/api-docs/menu-item -- 1.74 kB -- -1 B
/api-docs/menu-list -- 1.57 kB -- -1 B
/api-docs/menu -- 2.4 kB -- -1 B
/api-docs/mobile-stepper -- 1.93 kB -- -1 B
/api-docs/modal -- 2.42 kB -- -1 B
/api-docs/native-select -- 2.08 kB -- -1 B
/api-docs/no-ssr -- 1.3 kB -- -1 B
/api-docs/outlined-input -- 2.98 kB -- -1 B
/api-docs/pagination-item -- 1.97 kB -- -1 B
/api-docs/pagination -- 2.24 kB -- -1 B
/api-docs/paper -- 1.87 kB -- -1 B
/api-docs/popover -- 2.69 kB -- -1 B
/api-docs/popper -- 1.91 kB -- -1 B
/api-docs/portal -- 1.34 kB -- -1 B
/api-docs/radio-group -- 1.45 kB -- -1 B
/api-docs/radio -- 2.12 kB -- -1 B
/api-docs/rating -- 2.49 kB -- -1 B
/api-docs/root-ref -- 1.41 kB -- -1 B
/api-docs/scoped-css-baseline -- 1.4 kB -- -1 B
/api-docs/select -- 2.94 kB -- -1 B
/api-docs/skeleton -- 1.77 kB -- -1 B
/api-docs/slide -- 1.54 kB -- -1 B
/api-docs/slider -- 3.11 kB -- -1 B
/api-docs/snackbar-content -- 1.61 kB -- -1 B
/api-docs/snackbar -- 2.71 kB -- -1 B
/api-docs/speed-dial-action -- 2.04 kB -- -1 B
/api-docs/speed-dial-icon -- 1.55 kB -- -1 B
/api-docs/speed-dial -- 2.3 kB -- -1 B
/api-docs/step-button -- 1.63 kB -- -1 B
/api-docs/step-connector -- 1.54 kB -- -1 B
/api-docs/step-content -- 1.72 kB -- -1 B
/api-docs/step-icon -- 1.57 kB -- -1 B
/api-docs/step-label -- 1.9 kB -- -1 B
/api-docs/step -- 1.64 kB -- -1 B
/api-docs/stepper -- 1.84 kB -- -1 B
/api-docs/svg-icon -- 2.26 kB -- -1 B
/api-docs/swipeable-drawer -- 2 kB -- -1 B
/api-docs/switch -- 2.46 kB -- -1 B
/api-docs/tab-context -- 1.05 kB -- -1 B
/api-docs/tab-list -- 1.08 kB -- -1 B
/api-docs/tab-panel -- 1.45 kB -- -1 B
/api-docs/tab-scroll-button -- 1.61 kB -- -1 B
/api-docs/tab -- 1.99 kB -- -1 B
/api-docs/table-body -- 1.47 kB -- -1 B
/api-docs/table-cell -- 2.13 kB -- -1 B
/api-docs/table-container -- 1.48 kB -- -1 B
/api-docs/table-footer -- 1.47 kB -- -1 B
/api-docs/table-head -- 1.46 kB -- -1 B
/api-docs/table-pagination -- 2.46 kB -- -1 B
/api-docs/table-row -- 1.69 kB -- -1 B
/api-docs/table-sort-label -- 1.83 kB -- -1 B
/api-docs/table -- 1.68 kB -- -1 B
/api-docs/tabs -- 2.61 kB -- -1 B
/api-docs/text-field -- 3.18 kB -- -1 B
/api-docs/textarea-autosize -- 1.13 kB -- -1 B
/api-docs/toggle-button-group -- 1.86 kB -- -1 B
/api-docs/toggle-button -- 1.8 kB -- -1 B
/api-docs/toolbar -- 1.65 kB -- -1 B
/api-docs/tooltip -- 2.54 kB -- -1 B
/api-docs/tree-item -- 1.88 kB -- -1 B
/api-docs/tree-view -- 1.92 kB -- -1 B
/api-docs/typography -- 2.59 kB -- -1 B
/blog/2019-developer-survey-results -- 6.36 kB -- -1 B
/blog/2019 -- 4.24 kB -- -1 B
/blog/2020-introducing-sketch -- 3.5 kB -- -1 B
/blog/2020-q1-update -- 4.33 kB -- -1 B
/blog/april-2019-update -- 3.13 kB -- -1 B
/blog/august-2019-update -- 2.24 kB -- -1 B
/blog/december-2019-update -- 2.37 kB -- -1 B
/blog/july-2019-update -- 2.13 kB -- -1 B
/blog/june-2019-update -- 2.01 kB -- -1 B
/blog/march-2019-update -- 2.54 kB -- -1 B
/blog/material-ui-v1-is-out -- 6.67 kB -- -1 B
/blog/material-ui-v4-is-out -- 9.68 kB -- -1 B
/blog/may-2019-update -- 2.35 kB -- -1 B
/blog/november-2019-update -- 2.75 kB -- -1 B
/blog/september-2019-update -- 2.68 kB -- -1 B
/company/about -- 1.74 kB -- -1 B
/company/contact -- 1.33 kB -- -1 B
/company/jobs -- 1.35 kB -- -1 B
/components/about-the-lab -- 6.81 kB -- -1 B
/components/alert -- 12.5 kB -- -1 B
/components/autocomplete -- 99.4 kB -- -1 B
/components/avatars -- 8.83 kB -- -1 B
/components/backdrop -- 2.58 kB -- -1 B
/components/badges -- 15.4 kB -- -1 B
/components/bottom-navigation -- 6.27 kB -- -1 B
/components/box -- 8.05 kB -- -1 B
/components/breadcrumbs -- 14.7 kB -- -1 B
/components/button-group -- 7.37 kB -- -1 B
/components/buttons -- 26.2 kB -- -1 B
/components/cards -- 17.3 kB -- -1 B
/components/checkboxes -- 16.3 kB -- -1 B
/components/chips -- 21.8 kB -- -1 B
/components/click-away-listener -- 4.58 kB -- -1 B
/components/container -- 3.72 kB -- -1 B
/components/css-baseline -- 6.74 kB -- -1 B
/components/dialogs -- 42.8 kB -- -1 B
/components/dividers -- 12.7 kB -- -1 B
/components/drawers -- 31.5 kB -- -1 B
/components/expansion-panels -- 20.4 kB -- -1 B
/components/grid-list -- 12.1 kB -- -1 B
/components/grid -- 32.4 kB -- -1 B
/components/hidden -- 10.6 kB -- -1 B
/components/icons -- 27.3 kB -- -1 B
/components/links -- 6.91 kB -- -1 B
/components/lists -- 26.7 kB -- -1 B
/components/material-icons -- 729 kB -- -1 B
/components/menus -- 24.9 kB -- -1 B
/components/modal -- 11.9 kB -- -1 B
/components/no-ssr -- 5.11 kB -- -1 B
/components/pagination -- 9.45 kB -- -1 B
/components/paper -- 3.49 kB -- -1 B
/components/popover -- 17.4 kB -- -1 B
/components/popper -- 23.4 kB -- -1 B
/components/portal -- 3 kB -- -1 B
/components/progress -- 20.3 kB -- -1 B
/components/radio-buttons -- 14.8 kB -- -1 B
/components/rating -- 10.8 kB -- -1 B
/components/selects -- 30.9 kB -- -1 B
/components/skeleton -- 10.1 kB -- -1 B
/components/slider -- 15.6 kB -- -1 B
/components/steppers -- 36.6 kB -- -1 B
/components/switches -- 16.4 kB -- -1 B
/components/tables -- 143 kB -- -1 B
/components/tabs -- 21.3 kB -- -1 B
/components/text-fields -- 54.8 kB -- -1 B
/components/textarea-autosize -- 2.94 kB -- -1 B
/components/toggle-button -- 10.5 kB -- -1 B
/components/transfer-list -- 9.68 kB -- -1 B
/components/tree-view -- 11.2 kB -- -1 B
/components/typography -- 9.92 kB -- -1 B
/components/use-media-query -- 12.9 kB -- -1 B
/customization/breakpoints -- 16.2 kB -- -1 B
/customization/color -- 20.9 kB -- -1 B
/customization/components -- 38.4 kB -- -1 B
/customization/default-theme -- 8.8 kB -- -1 B
/customization/density -- 9.75 kB -- -1 B
/customization/globals -- 4.72 kB -- -1 B
/customization/palette -- 14.1 kB -- -1 B
/customization/spacing -- 2.61 kB -- -1 B
/customization/typography -- 11.8 kB -- -1 B
/customization/z-index -- 3.13 kB -- -1 B
/discover-more/backers -- 3.04 kB -- -1 B
/discover-more/changelog -- 1.44 kB -- -1 B
/discover-more/languages -- 3.44 kB -- -1 B
/discover-more/related-projects -- 7.95 kB -- -1 B
/discover-more/roadmap -- 3.72 kB -- -1 B
/discover-more/showcase -- 13.4 kB -- -1 B
/discover-more/team -- 6.67 kB -- -1 B
/discover-more/vision -- 6.68 kB -- -1 B
/getting-started/example-projects -- 6.8 kB -- -1 B
/getting-started/faq -- 36.1 kB -- -1 B
/getting-started/installation -- 7.83 kB -- -1 B
/getting-started/learn -- 8.92 kB -- -1 B
/getting-started/support -- 9.02 kB -- -1 B
/getting-started/supported-components -- 6.42 kB -- -1 B
/getting-started/supported-platforms -- 5.76 kB -- -1 B
/getting-started/templates -- 8.91 kB -- -1 B
/getting-started/templates/album -- 5.59 kB -- -1 B
/getting-started/templates/blog -- 7.45 kB -- -1 B
/getting-started/templates/checkout -- 11.2 kB -- -1 B
/getting-started/templates/dashboard -- 8.86 kB -- -1 B
/getting-started/templates/pricing -- 7.8 kB -- -1 B
/getting-started/templates/sign-in-side -- 9.29 kB -- -1 B
/getting-started/templates/sign-in -- 9.53 kB -- -1 B
/getting-started/templates/sign-up -- 9.64 kB -- -1 B
/getting-started/templates/sticky-footer -- 1.54 kB -- -1 B
/getting-started/usage -- 9.58 kB -- -1 B
/guides/api -- 15.8 kB -- -1 B
/guides/composition -- 14.9 kB -- -1 B
/guides/flow -- 2.26 kB -- -1 B
/guides/interoperability -- 16.3 kB -- -1 B
/guides/localization -- 11.7 kB -- -1 B
/guides/migration-v0x -- 7.39 kB -- -1 B
/guides/migration-v3 -- 19.2 kB -- -1 B
/guides/minimizing-bundle-size -- 8.7 kB -- -1 B
/guides/responsive-ui -- 4.27 kB -- -1 B
/guides/right-to-left -- 6.77 kB -- -1 B
/guides/server-rendering -- 8.75 kB -- -1 B
/guides/testing -- 8.61 kB -- -1 B
/guides/typescript -- 14.6 kB -- -1 B
/performance/table-component -- 1.44 kB -- -1 B
/performance/table-emotion -- 8.5 kB -- -1 B
/performance/table-hook -- 2.24 kB -- -1 B
/performance/table-mui -- 4.49 kB -- -1 B
/performance/table-raw -- 613 B -- -1 B
/performance/table-styled-components -- 2.6 kB -- -1 B
/premium-themes/onepirate/forgot-password -- 1.01 kB -- -1 B
/premium-themes/onepirate/privacy -- 4.44 kB -- -1 B
/premium-themes/onepirate/sign-in -- 1.07 kB -- -1 B
/premium-themes/onepirate/sign-up -- 1.12 kB -- -1 B
/premium-themes/onepirate/terms -- 11.8 kB -- -1 B
/premium-themes/paperbase -- 8.96 kB -- -1 B
/styles/advanced -- 33.3 kB -- -1 B
/styles/api -- 16.9 kB -- -1 B
/styles/basics -- 16.5 kB -- -1 B
/system/api -- 5.96 kB -- -1 B
/system/basics -- 27.4 kB -- -1 B
/system/borders -- 4.1 kB -- -1 B
/system/display -- 6.55 kB -- -1 B
/system/flexbox -- 5.85 kB -- -1 B
/system/palette -- 4.35 kB -- -1 B
/system/positions -- 2.53 kB -- -1 B
/system/shadows -- 3.85 kB -- -1 B
/system/sizing -- 3.53 kB -- -1 B
/system/spacing -- 6.01 kB -- -1 B
/system/typography -- 4.41 kB -- -1 B
/versions -- 23.7 kB -- -1 B
docs:chunk:shared -- 61.7 kB -- -1 B
docs:shared:chunk/commons -- 5.99 kB -- -1 B
docs:shared:chunk/framework -- 42.3 kB -- -1 B
docs:shared:runtime/main -- 6.78 kB -- -1 B
docs:shared:runtime/webpack -- 1.24 kB -- -1 B
bundle Size Change Size Gzip Change Gzip
@material-ui/core ▼ -4.48 kB (-1.19% ) 371 kB ▼ -789 B (-0.77% ) 102 kB
Slide ▼ -3.67 kB (-10.53% ) 31.1 kB ▼ -167 B (-1.60% ) 10.3 kB
Collapse ▼ -3.49 kB (-4.50% ) 74 kB ▲ +54 B (+0.24% ) 22.9 kB
Fade ▼ -3.36 kB (-10.26% ) 29.4 kB ▼ -27 B (-0.27% ) 9.84 kB
Grow ▼ -3.35 kB (-10.03% ) 30 kB ▼ -34 B (-0.34% ) 10.1 kB
Zoom ▼ -3.32 kB (-10.13% ) 29.4 kB ▲ +119 B (+1.21% ) 9.97 kB
@material-ui/core[umd] ▼ -2.81 kB (-0.85% ) 326 kB ▲ +222 B (+0.23% ) 94.9 kB
@material-ui/lab ▲ +1.63 kB (+0.76% ) 217 kB ▲ +624 B (+0.97% ) 64.9 kB
StepContent ▲ +1.01 kB (+1.36% ) 75.1 kB ▲ +394 B (+1.70% ) 23.6 kB
ExpansionPanel ▲ +1.01 kB (+1.31% ) 77.5 kB ▲ +364 B (+1.51% ) 24.5 kB
SwipeableDrawer ▲ +885 B (+0.91% ) 98.2 kB ▲ +280 B (+0.91% ) 30.9 kB
Drawer ▲ +877 B (+0.98% ) 90.8 kB ▲ +308 B (+1.12% ) 27.7 kB
Snackbar ▲ +778 B (+0.96% ) 81.5 kB ▲ +324 B (+1.28% ) 25.7 kB
Tooltip ▲ +775 B (+0.73% ) 107 kB ▲ +293 B (+0.87% ) 34 kB
Select ▲ +775 B (+0.64% ) 122 kB ▲ +285 B (+0.79% ) 36.4 kB
Popover ▲ +773 B (+0.88% ) 88.7 kB ▲ +279 B (+1.02% ) 27.5 kB
TextField ▲ +770 B (+0.59% ) 131 kB ▲ +285 B (+0.75% ) 38.5 kB
Menu ▲ +770 B (+0.82% ) 94.4 kB ▲ +283 B (+0.98% ) 29.2 kB
SpeedDialAction ▲ +765 B (+0.62% ) 123 kB ▲ +309 B (+0.79% ) 39.3 kB
TablePagination ▲ +758 B (+0.51% ) 148 kB ▲ +284 B (+0.65% ) 43.8 kB
Dialog ▲ +750 B (+0.85% ) 88.7 kB ▲ +286 B (+1.04% ) 27.9 kB
Backdrop ▲ +745 B (+1.02% ) 73.6 kB ▲ +300 B (+1.33% ) 22.8 kB
SpeedDial ▲ +737 B (+0.81% ) 91.6 kB ▲ +312 B (+1.08% ) 29.1 kB
TreeItem ▲ +663 B (+0.83% ) 80.9 kB ▲ +296 B (+1.16% ) 25.8 kB
docs:/ ▼ -100 B (-0.83% ) 11.9 kB -- -1 B
Autocomplete ▼ -21 B (-0.02% ) 136 kB ▼ -5 B (-0.01% ) 42.9 kB
Chip ▼ -21 B (-0.02% ) 87.2 kB ▼ -4 B (-0.01% ) 26.8 kB
Pagination ▼ -21 B (-0.02% ) 89 kB ▼ -2 B (-0.01% ) 27.5 kB
MenuItem ▼ -21 B (-0.03% ) 82.7 kB ▼ -1 B (-0.00% ) 26 kB
Fab ▼ -19 B (-0.02% ) 81.3 kB ▼ -5 B (-0.02% ) 25.4 kB
ListItem ▼ -18 B (-0.02% ) 81.6 kB ▼ -2 B (-0.01% ) 25.6 kB
Tabs ▼ -16 B (-0.02% ) 90.5 kB ▼ -5 B (-0.02% ) 28.3 kB
TabScrollButton ▼ -16 B (-0.02% ) 81.5 kB ▼ -3 B (-0.01% ) 25.6 kB
Button ▼ -15 B (-0.02% ) 84.2 kB ▼ -5 B (-0.02% ) 25.9 kB
IconButton ▼ -15 B (-0.02% ) 80.6 kB ▼ -4 B (-0.02% ) 25.3 kB
PaginationItem ▼ -15 B (-0.02% ) 85.3 kB ▼ -3 B (-0.01% ) 26.4 kB
Checkbox ▼ -13 B (-0.01% ) 86.7 kB ▼ -45 B (-0.16% ) 27.5 kB
Tab ▼ -13 B (-0.02% ) 81 kB ▼ -11 B (-0.04% ) 25.8 kB
ButtonGroup ▼ -13 B (-0.01% ) 87.9 kB ▲ +10 B (+0.04% ) 27.2 kB
StepButton ▼ -13 B (-0.01% ) 86.8 kB ▼ -9 B (-0.03% ) 27.5 kB
Switch ▼ -13 B (-0.02% ) 85.9 kB ▼ -8 B (-0.03% ) 27.1 kB
Radio ▼ -13 B (-0.01% ) 87.7 kB ▼ -7 B (-0.03% ) 27.9 kB
Alert ▼ -13 B (-0.01% ) 87.8 kB ▼ -5 B (-0.02% ) 27.8 kB
TabList ▼ -13 B (-0.01% ) 91.7 kB ▼ -5 B (-0.02% ) 29.4 kB
CardActionArea ▼ -13 B (-0.02% ) 79.6 kB ▼ -4 B (-0.02% ) 25.2 kB
ButtonBase ▼ -13 B (-0.02% ) 78.5 kB ▲ +2 B (+0.01% ) 24.7 kB
ToggleButton ▼ -13 B (-0.02% ) 80.6 kB ▼ -2 B (-0.01% ) 25.6 kB
ExpansionPanelSummary ▼ -13 B (-0.02% ) 82.6 kB ▲ +1 B (0.00% ) 26.3 kB
TableSortLabel ▼ -13 B (-0.02% ) 81.9 kB ▲ +1 B (0.00% ) 26.1 kB
BottomNavigationAction ▼ -13 B (-0.02% ) 80 kB -- 25.4 kB
Breadcrumbs ▼ -13 B (-0.02% ) 85 kB -- 27 kB
RadioGroup ▼ -8 B (-0.01% ) 68.8 kB ▲ +2 B (+0.01% ) 21.4 kB
OutlinedInput ▼ -6 B (-0.01% ) 79.7 kB ▼ -5 B (-0.02% ) 24.9 kB
FilledInput ▼ -6 B (-0.01% ) 78.7 kB ▼ -4 B (-0.02% ) 24.5 kB
FormControl ▼ -6 B (-0.01% ) 69.3 kB ▲ +3 B (+0.01% ) 21.6 kB
MenuList ▼ -5 B (-0.01% ) 70.9 kB ▲ +3 B (+0.01% ) 22.2 kB
FormLabel ▼ -5 B (-0.01% ) 68.4 kB -- 21.2 kB
StepIcon ▼ -4 B (-0.01% ) 69.5 kB ▲ +6 B (+0.03% ) 21.7 kB
Avatar ▼ -3 B (-0.00% ) 70 kB ▲ +5 B (+0.02% ) 22 kB
List ▼ -3 B (-0.00% ) 67.2 kB ▲ +3 B (+0.01% ) 21 kB
Input ▼ -3 B (-0.00% ) 77.6 kB ▼ -2 B (-0.01% ) 24.3 kB
StepLabel ▼ -2 B (-0.00% ) 73.4 kB ▲ +5 B (+0.02% ) 22.8 kB
LinearProgress ▼ -2 B (-0.00% ) 70.2 kB ▲ +4 B (+0.02% ) 21.8 kB
FormHelperText ▼ -2 B (-0.00% ) 68.2 kB ▼ -1 B (-0.00% ) 21.2 kB
InputLabel ▼ -2 B (-0.00% ) 70.2 kB -- 21.7 kB
Typography ▼ -1 B (-0.00% ) 68.5 kB ▲ +5 B (+0.02% ) 21.4 kB
InputBase ▼ -1 B (-0.00% ) 75.7 kB ▼ -2 B (-0.01% ) 23.8 kB
@material-ui/system -- 17.2 kB ▲ +11 B (+0.24% ) 4.52 kB
Box -- 73.8 kB ▼ -10 B (-0.04% ) 22.4 kB
FormControlLabel -- 70.4 kB ▲ +7 B (+0.03% ) 22.2 kB
AppBar -- 68.9 kB ▲ +5 B (+0.02% ) 21.7 kB
CardMedia -- 67.2 kB ▲ +5 B (+0.02% ) 21.2 kB
Divider -- 67.6 kB ▲ +5 B (+0.02% ) 21.3 kB
GridListTileBar -- 68.1 kB ▲ +5 B (+0.02% ) 21.4 kB
ListSubheader -- 67.7 kB ▲ +5 B (+0.02% ) 21.3 kB
NativeSelect -- 81.9 kB ▼ -5 B (-0.02% ) 26 kB
Step -- 67.6 kB ▲ +5 B (+0.02% ) 21.2 kB
SvgIcon -- 67.9 kB ▲ +5 B (+0.02% ) 21.2 kB
TableHead -- 67 kB ▼ -5 B (-0.02% ) 21 kB
@material-ui/styles -- 52.1 kB ▲ +4 B (+0.03% ) 15.6 kB
CardActions -- 66.9 kB ▼ -4 B (-0.02% ) 21 kB
Grid -- 70 kB ▼ -4 B (-0.02% ) 22.1 kB
InputAdornment -- 70 kB ▲ +4 B (+0.02% ) 22.1 kB
TableFooter -- 67 kB ▼ -4 B (-0.02% ) 21 kB
useAutocomplete -- 15 kB ▼ -4 B (-0.08% ) 5.28 kB
BottomNavigation -- 67.3 kB ▲ +3 B (+0.01% ) 21.1 kB
Card -- 67.7 kB ▲ +3 B (+0.01% ) 21.3 kB
CardContent -- 66.9 kB ▼ -3 B (-0.01% ) 21 kB
DialogContent -- 67.1 kB ▼ -3 B (-0.01% ) 21.1 kB
ExpansionPanelDetails -- 66.9 kB ▼ -3 B (-0.01% ) 21 kB
Icon -- 67.7 kB ▲ +3 B (+0.01% ) 21.2 kB
ListItemAvatar -- 67 kB ▲ +3 B (+0.01% ) 21 kB
Paper -- 67.2 kB ▲ +3 B (+0.01% ) 21 kB
Popper -- 28.8 kB ▲ +3 B (+0.03% ) 10.3 kB
Slider -- 80.9 kB ▲ +3 B (+0.01% ) 25.9 kB
SpeedDialIcon -- 69.4 kB ▲ +3 B (+0.01% ) 21.9 kB
Stepper -- 69.8 kB ▲ +3 B (+0.01% ) 22 kB
AlertTitle -- 69.1 kB ▲ +2 B (+0.01% ) 21.8 kB
Badge -- 70.2 kB ▲ +2 B (+0.01% ) 22 kB
GridListTile -- 68.6 kB ▲ +2 B (+0.01% ) 21.6 kB
Hidden -- 70.9 kB ▲ +2 B (+0.01% ) 22.3 kB
Link -- 71.5 kB ▲ +2 B (+0.01% ) 22.7 kB
NoSsr -- 2.18 kB ▼ -2 B (-0.19% ) 1.03 kB
SnackbarContent -- 68.4 kB ▲ +2 B (+0.01% ) 21.6 kB
TableBody -- 67 kB ▲ +2 B (+0.01% ) 21 kB
TableCell -- 69 kB ▲ +2 B (+0.01% ) 21.8 kB
TableContainer -- 66.9 kB ▲ +2 B (+0.01% ) 21 kB
TextareaAutosize -- 5.24 kB ▼ -2 B (-0.09% ) 2.19 kB
AvatarGroup -- 71.1 kB ▼ -1 B (-0.00% ) 22.6 kB
CardHeader -- 69.9 kB ▲ +1 B (0.00% ) 22.1 kB
ClickAwayListener -- 4.13 kB ▼ -1 B (-0.06% ) 1.65 kB
Container -- 68.1 kB ▼ -1 B (-0.00% ) 21.3 kB
CssBaseline -- 66.9 kB ▲ +1 B (0.00% ) 21.1 kB
DialogActions -- 67 kB ▲ +1 B (0.00% ) 21.1 kB
ExpansionPanelActions -- 67 kB ▼ -1 B (-0.00% ) 21 kB
GridList -- 67.4 kB ▼ -1 B (-0.00% ) 21.2 kB
ListItemSecondaryAction -- 66.9 kB ▲ +1 B (0.00% ) 21 kB
ListItemText -- 69.9 kB ▲ +1 B (0.00% ) 22 kB
Modal -- 15 kB ▲ +1 B (+0.02% ) 5.25 kB
Portal -- 2.87 kB ▼ -1 B (-0.08% ) 1.29 kB
ScopedCssBaseline -- 67.8 kB ▲ +1 B (0.00% ) 21.3 kB
Skeleton -- 67.9 kB ▲ +1 B (0.00% ) 21.5 kB
StepConnector -- 67.6 kB ▲ +1 B (0.00% ) 21.3 kB
TabContext -- 2.65 kB ▼ -1 B (-0.09% ) 1.15 kB
Table -- 67.5 kB ▲ +1 B (0.00% ) 21.2 kB
TableRow -- 67.4 kB ▲ +1 B (0.00% ) 21.2 kB
ToggleButtonGroup -- 68.1 kB ▲ +1 B (0.00% ) 21.5 kB
TreeView -- 73.4 kB ▲ +1 B (0.00% ) 23.1 kB
useMediaQuery -- 2.57 kB ▼ -1 B (-0.09% ) 1.06 kB
CircularProgress -- 69 kB -- 21.8 kB
colorManipulator -- 3.96 kB -- 1.55 kB
DialogContentText -- 68.9 kB -- 21.7 kB
DialogTitle -- 69.2 kB -- 21.8 kB
docs:/_app -- 37 kB -- -1 B
FormGroup -- 66.9 kB -- 21 kB
ListItemIcon -- 67.1 kB -- 21.1 kB
MobileStepper -- 72.7 kB -- 22.9 kB
Rating -- 75.7 kB -- 24.4 kB
RootRef -- 4.64 kB -- 1.76 kB
styles/createMuiTheme -- 22.4 kB -- 7.75 kB
TabPanel -- 70 kB -- 22 kB
Toolbar -- 67.2 kB -- 21.2 kB
useScrollTrigger -- 2.66 kB -- 1.08 kB

Generated by 🚫 dangerJS against dbf3d00

oliviertassinari
oliviertassinari reviewed May 8, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks great

packages/material-ui/src/Collapse/Collapse.d.ts Outdated Show resolved Hide resolved
packages/material-ui/src/Collapse/Collapse.js Outdated Show resolved Hide resolved
@eps1lon eps1lon force-pushed the feat/strict-mode-transitions branch 4 times, most recently from 1b06571 to 75b220b Compare May 9, 2020 11:35
@eps1lon eps1lon added this to the 16.8 React.StrictMode milestone May 9, 2020
@eps1lon eps1lon added component: transitions This is the name of the generic UI component, not the React module! new feature New feature or request labels May 9, 2020
@eps1lon eps1lon marked this pull request as ready for review May 9, 2020 11:39
oliviertassinari
oliviertassinari reviewed May 9, 2020
View reviewed changes
docs/src/pages/customization/theming/theming.md Outdated Show resolved Hide resolved
docs/src/pages/customization/theming/theming.md
return (
<React.StrictMode>
<ThemeProvider theme={unstable_createMuiStrictModeTheme()}>
<LandingPage />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example doesn't illustrate disableStrictModeCompat.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an example to the Disable StrictMode compatibility partially section

@eps1lon eps1lon force-pushed the feat/strict-mode-transitions branch from 75b220b to 2454c76 Compare May 9, 2020 13:01
@eps1lon eps1lon force-pushed the feat/strict-mode-transitions branch from 56278e3 to dbf3d00 Compare May 9, 2020 18:01
@eps1lon eps1lon merged commit 1f68ceb into mui:master May 9, 2020
@eps1lon eps1lon deleted the feat/strict-mode-transitions branch May 9, 2020 18:26
@iamhosseindhv iamhosseindhv mentioned this pull request May 17, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: transitions This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
React.StrictMode
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari