-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SpeedDial] Improve tooltip work break #21359
Merged
oliviertassinari
merged 1 commit into
mui:master
from
SugiKent:fix-speed-dial-tooltip-word-break
Jun 7, 2020
Merged
[SpeedDial] Improve tooltip work break #21359
oliviertassinari
merged 1 commit into
mui:master
from
SugiKent:fix-speed-dial-tooltip-word-break
Jun 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: fea1887...579949c Details of page changes
|
SugiKent
changed the title
Make literals be Horizontal in Tooltip of SpeedDialAction
[SpeedDialAction ] Make literals be Horizontal in Tooltip of SpeedDialAction
Jun 7, 2020
oliviertassinari
added
component: speed dial
This is the name of the generic UI component, not the React module!
bug 🐛
Something doesn't work
labels
Jun 7, 2020
oliviertassinari
changed the title
[SpeedDialAction ] Make literals be Horizontal in Tooltip of SpeedDialAction
[SpeedDial] Improve tooltip work break
Jun 7, 2020
oliviertassinari
approved these changes
Jun 7, 2020
joshwooding
approved these changes
Jun 7, 2020
thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: speed dial
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltip of SpeedDialAction didn't support Japanese literal style, so I added word break property to
staticTooltipLabel
in order to avoid that the word is vertical.I think that literals in the tooltip should be horizontal in any languages.
However I don't know why the tooltip is vertical in Japanese. Cloud you comment the reason if you have any ideas.
Before
After
Try it