-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve legibility of required star #21369
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 644fe8c...dc1865f Details of page changes
|
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jun 9, 2020
eps1lon
force-pushed
the
docs/required-readability
branch
from
June 9, 2020 07:31
e91344c
to
dc1865f
Compare
eps1lon
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jun 9, 2020
oliviertassinari
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When imcreasing the default font size the
*
for required props move farther away from the prop name which can look confusing. By removing the space the*
stays attached to the prop name. Double clicking the prop name still only selects the prop name (and excludes the*
) on chrome.Before:
After:
Preview: http://deploy-preview-21369--material-ui.netlify.app/api/autocomplete#props