-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Use rem in responsive font sizes chart #21373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes vertical axis from `font-size (px)` to `font-size (rem)` which better matches the vertical axis values.
Details of bundle changes.Comparing: d52d29c...568c42c Details of page changes
|
eps1lon
changed the title
Fixes mui-org#21372 [Docs] Responsive Font Sizes Chart uses px
[docs] Use rem in responsive font sizes chart
Jun 9, 2020
@thewidgetsmith Much appreciated, thanks! |
Thanks for fixing the inconsistency between the label and the unit. Regarding using px vs rem. What do you think of the tradeoff of https://github.com/twbs/rfs? They use rem in the CSS, like us, but use px in the chart. This seems simpler to understand. |
curtislin7
pushed a commit
to curtislin7/material-ui
that referenced
this pull request
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes vertical axis from
font-size (px)
tofont-size (rem)
whichbetter matches the vertical axis values.
Edit @eps1lon: Closes #21372