-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snackbar] Change the default position on desktop #21980
[Snackbar] Change the default position on desktop #21980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests should reflect this change since they're now failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you deviating from the current tradeoff? Why using JavaScript when we can use the CSS media queries to change the position of the snackbar? Wouldn't we use CSS to better handle the initial paint?
I had a short-sighted mind. I went for JS simply because I use them when working on our project often (which should be fixed). changed like this for now (bb9c2d5) (i have to add like |
f8f49c2
to
1b2e2c9
Compare
@kodai3 What do you think of the proposed changes? |
Well done |
Breaking change
The notification now displays at the bottom left on large screens.
It better matches the behavior of Gmail, Google Keep, material.io, etc.
You can restore the previous behavior with:
I have followed (at least) the PR section of the contributing guide.
This is in the v5 breaking change scope
creating PR as i'm in favor of this proposal