Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Fix various issues with the new cli on windows #23381

Merged
merged 5 commits into from
Nov 3, 2020
Merged

[test] Fix various issues with the new cli on windows #23381

merged 5 commits into from
Nov 3, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Nov 3, 2020

  1. fix "yarn enoent" in windows
  2. throw when no files matches
  3. Fix gitignore not working on windows

@eps1lon eps1lon added the test label Nov 3, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Nov 3, 2020 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against c0ca7e0

@eps1lon eps1lon requested a review from mnajdova November 3, 2020 18:06
@eps1lon
Copy link
Member Author

eps1lon commented Nov 3, 2020

@mnajdova Could you check if it's working on your machine now? Feel free to merge if it does.

mnajdova
mnajdova approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works now 🙇‍♀️

@mnajdova mnajdova merged commit 6c61771 into mui:next Nov 3, 2020
@eps1lon eps1lon deleted the test/win-cli branch September 14, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @mnajdova