[test] Use fake timers in visual regression tests #23464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #22692 we now have visual regression tests relying on
Date
which means they produce different output depending on the time they're run.Using
sinon#useFakeTimers
to run the tests with the same (mocked) time. This also mocks all other timer related things so the tests should be even "more stable" though we haven't had any timer related flakyness. But it could still mean that we run less timer related stuff (e.g. passive effects?).We'll see if this works. Otherwise I'll just stub the
Date
constructor.