-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Batch small changes #23678
[core] Batch small changes #23678
Conversation
@mbrookes When I wrote "application", I wanted to make a reference to a web application which excludes websites. If you had interpreted it as a purpose used, then, why not. However, I think it's confusing. It's not clear what it refers to. |
Grammarly motives the change with: "Using a long phrase when a shorter one (or even a single word) will suffice can contribute to wordiness or vagueness. Though a sentence may be grammatically correct, writing more concisely is often a better choice. Consider your reader and context to make a determination." |
@mbrookes All yours, feel free to apply the suggestions. |
Considering the context, it's clearer with. Considering the reader (possibly non-native English speaking), perhaps without, so let's go with your change. |
Co-authored-by: Matt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Quite some stuff I've been sleeping on.
sx
prop was empty in the third test case.