Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Batch small changes #23678

Merged
merged 10 commits into from
Nov 23, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 22, 2020

  • [core] Add missing space in scripts 5d6cf2d: minor change
  • [docs] Be more generic f9e170a: developers can build websites too with React
  • [docs] Add v4 redirection to v5 too 32ec009: it was added in [Dialog] Add deprecation warning for withMobileDialog #23570.
  • [docs] Fix typos 2b942e5: 🤷‍♂️
  • [docs] Remove StackBlitz 80c7951: 1. the link is barely used looking at the analytics, 2. the link is broken, it was raised by a developer trying to create a reproduction for a bug 3. they permanently show an ad for a competitor.
  • [docs] Avoid confusion 12ea597: Marija thought the sx prop was empty in the third test case.
  • [docs] Add missing label on toolbar 64a7ab5: it seems to have been lost during the resolution of a merge conflict, probably my fault. It doesn't impact v4.

Capture d’écran 2020-11-22 à 17 52 23

@oliviertassinari oliviertassinari added the umbrella For grouping multiple issues to provide a holistic view label Nov 22, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Nov 22, 2020

Details of bundle changes

Generated by 🚫 dangerJS against 42bf3ee

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Nov 22, 2020

https://www.dictionary.com/browse/application

@mbrookes When I wrote "application", I wanted to make a reference to a web application which excludes websites. If you had interpreted it as a purpose used, then, why not. However, I think it's confusing. It's not clear what it refers to.

@oliviertassinari
Copy link
Member Author

https://www.dictionary.com/browse/in-order

Grammarly motives the change with: "Using a long phrase when a shorter one (or even a single word) will suffice can contribute to wordiness or vagueness. Though a sentence may be grammatically correct, writing more concisely is often a better choice. Consider your reader and context to make a determination."

@oliviertassinari
Copy link
Member Author

@mbrookes All yours, feel free to apply the suggestions.

packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated Show resolved Hide resolved
docs/src/pages/system/basics/basics.md Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
@mbrookes
Copy link
Member

Consider your reader and context to make a determination.

Considering the context, it's clearer with. Considering the reader (possibly non-native English speaking), perhaps without, so let's go with your change.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Quite some stuff I've been sleeping on.

@oliviertassinari oliviertassinari merged commit e3db027 into mui:next Nov 23, 2020
@oliviertassinari oliviertassinari deleted the batch-small-changes-v40 branch November 23, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants