Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[benchmark] Update dependencies with latest #23694

Merged
merged 1 commit into from
Nov 24, 2020
Merged

[benchmark] Update dependencies with latest #23694

merged 1 commit into from
Nov 24, 2020

Conversation

oliviertassinari
Copy link
Member

Solve the following warnings when installing the dependencies:

Capture d’écran 2020-11-23 à 22 53 54

@oliviertassinari oliviertassinari changed the title [benchmark] Update with latest [benchmark] Update dependencies with latest Nov 23, 2020
@mnajdova
Copy link
Member

I did some changes for it on https://github.com/mui-org/material-ui/pull/23688/files but we decided to go with different packages. I’ll take a look tomorrow what the Box represents in chakra and whether that one is closer for comparison.

@oliviertassinari oliviertassinari marked this pull request as draft November 23, 2020 22:29
mnajdova
mnajdova approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that chakra's Box - https://chakra-ui.com/docs/layout/box is closer to our Box component, see the support for the as prop as well. But let's add this one and we can add along the way scenario with the Box component too.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Nov 24, 2020 •
edited
Loading

@mnajdova No preferences, happy to close this PR if you think it's not needed. I have first tried to install @chakra/react but when I saw all the packages installed, I got compelled to search if they didn't have a package with only the system.

@oliviertassinari oliviertassinari marked this pull request as ready for review November 24, 2020 10:02
@oliviertassinari oliviertassinari merged commit 7b1695a into mui:next Nov 24, 2020
@oliviertassinari oliviertassinari deleted the update-benchmark-with-latest branch November 24, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @mnajdova