[Autocomplete] Better isolate test case #23704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
test
component: autocomplete
eps1lon
previously requested changes
Nov 25, 2020
There was a problem hiding this comment.
Enter isn't actually triggering submit when dispatched programmatically.
True. It seems to be good enough in our case. It doesn't seem that we need this more resilient approach: https://github.com/mui-org/material-ui/blob/062ea1f734f7bb112f972a7147e8e08d391d6e1b/packages/material-ui/src/Autocomplete/Autocomplete.test.js#L483-L505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opportunity was found in #23487. These two tests are interesting in what happens when the user press Enter and more specifically if the event bubble up to a potential parent
<form>element to trigger the submit. By refactoring the test, we avoid early returns like: https://github.com/mui-org/material-ui/blob/dfc94e03d391384155cbdd1a0e3b0fe16e2e1042/packages/material-ui/src/useAutocomplete/useAutocomplete.js#L731