[styles] Update mergeClasses types to more closely match its implementation #23705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
approved these changes
Nov 24, 2020
oliviertassinari
added
package: styles
|
@etrepum It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
|
Thanks for the quick review, well beyond expectations! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types for
mergeClassesdidn't quite match its implementation. In particular,newClassesandComponentare optional, and the values innewClassesshould also be allowed to be optional.This showed up in practice when you are using the
classesprop directly from aStyledComponentProps<ClassKey>interface which is aundefined | Partial<ClassNameMap<ClassKey>>so if set, all of the props inclassesare optional.