Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmark] Improve printed results #23729

Merged
merged 4 commits into from
Nov 26, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 26, 2020

Use https://necolas.github.io/react-native-web/benchmarks/ as inspiration:

  • Display the standard deviation
  • Increase the number of runs from 10 to 15
  • Create a test case array for simplicity
  • Turn into % display to be more CPU agnostic (help with collaboration)
noop (baseline):
  04.59 ±00.10ms
React primitives:
  44.05 ±02.19ms
React components:
  126 ±8%
Styled Material-UI:
  174 ±6%
Styled emotion:
  163 ±6%
Styled SC:
  191 ±5%
makeStyles:
  168 ±6%
Box Baseline:
  180 ±4%
Box Material-UI:
  377 ±6%
Box Theme-UI:
  316 ±6%
Box Chakra-UI:
  269 ±9%
styled-components Box + @material-ui/system:
  358 ±8%
styled-components Box + styled-system:
  307 ±9%

@mnajdova Could you run the script locally and commit the printed output in the markdown so we can evaluate if it's stable or not (on this PR)?

@mui-pr-bot
Copy link

mui-pr-bot commented Nov 26, 2020

No bundle size changes

Generated by 🚫 dangerJS against 9671c4c

@mnajdova
Copy link
Member

@mnajdova Could you run the script locally and commit the printed output in the markdown so we can evaluate if it's stable or not (on this PR)?

@oliviertassinari here it is 980a9c8

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Nov 26, 2020

Thanks, it's not very stable, it would benefit from more. However, we have enough precision to clearly see the difference of performance between the different options. Maybe if it was running in the CI it would have a smaller std.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 26, 2020
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 26, 2020
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The info is def more useful than previosly 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants