[test] Cleanup skipped tests #23732
Merged
[test] Cleanup skipped tests #23732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
test/edg-vs-edge
branch
from
f361847 to
f9a91dc
Compare
oliviertassinari
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Became obsolete with [core] Ship modern bundle #22814
This can be abused up until adding a test becomes a balancing act. For example, in SwipeableDrawer where we return in the middle of the test file (not touching that test for now because it seems too brittle). This is the old problem of "optimizing for the current test suite". A test suite needs to scale and every addition needs to start from a clean slate. And a change to existing tests should not affect existing one.
By using skip() we can also better monitor which tests are skipped across environments. This was only possible implicitly. Now we have an explicit signal in test runners.