[test] Stay busy until document.fonts is ready #23736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
approved these changes
Nov 27, 2020
I'm just going to claim this solved it if we never see it again 😁 |
Looks like it didn't fix it 100%: https://www.argos-ci.com/mui-org/material-ui/builds/5769 Though it does seem to have reduced flakiness. |
|
Maybe we should give up on this one. What about we skip the visual test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still experiencing flaky tests when a single tests loads some additional web fonts.
So we're now leveraging
FontFaceSetand listen toloadingandloadingdoneevents. In these events we flip the ready state depending ondocument.fonts.status. Hopefully this resolves the last issues.It's an experimental feature but shipped by browsers supported by
playwright.