[core] Use Lerna to publish #23793

oliviertassinari · 2020-11-30T23:25:17Z

Closes #23785. The usage of Lerna should solve the pain around managing the version between the different packages. I have been doing it by hand so far. However, it's error-prone, doesn't scale with the number of packages, and time-consuming.

mui-pr-bot · 2020-11-30T23:27:59Z

No bundle size changes

Generated by 🚫 dangerJS against 51cbda0

eps1lon

What are all the changes to the tsconfigs for?

eps1lon · 2020-12-01T15:48:40Z

package.json

+    "release": "yarn build:release && lerna publish --no-changelog --dist-tag next --contents build",
+    "publish:dry-run": "lerna publish --no-changelog --dist-tag next --contents build --no-git-tag-version --no-push --registry=\"http://localhost:4873/\"",


Could you add some docs to the release process while we're at it? It's unclear how this should be used.

Sure, I would be happy too. The objective of the dry-run command was to test that the release process works end-to-end. I have used https://github.com/verdaccio/verdaccio.

Could you add some docs to the release process while we're at it?

Done https://trello.com/c/H7Tz29ft/2763-release-steps. It's almost identical to the release steps of Material-UI X.

I meant documenting as in adding a section to CONTRIBUTING.md so that we can always keep it in sync.

I think that moving it to git would have the opposite effect, it will make updating the instructions more painful (opening a PR vs. doing the edits directly), so more likely to go out of sync. I think it's why the GitHub Wiki is using a different edit workflow tradeoff. Many of the steps are not directly related to the code. But happy to give it a try if you think it's important.

(opening a PR vs. doing the edits directly),

I suspected that you're less and less interested in having your work reviewed. But you seem to be doing fine with just committing if you don't want people to review it. Why would that not work here?

it will make updating the instructions more painful

Then we need to work on the pain points when opening a PR. What are frequent problems you run into?

I think that keeping in sync and helping with reviews are two different topics. I thought the concern was with keeping in sync with the code.

I had assumed that we wouldn't need to review changes to the release workflow instructions, that they are meant to be an unbiased list of steps to follow, that if there is a mistake in it, anybody would go and update the instructions to fix them.

I had also assumed that reviewing the release workflow would require a different discussion. I'm still happy to do it if you think it's important. React has it documented in git: https://github.com/facebook/react/blob/master/scripts/release/README.md.

I had assumed that we wouldn't need to review changes to the release workflow instructions, that they are meant to be an unbiased list of steps to follow, that if there is a mistake in it, anybody would go and update the instructions to fix them.

Same exact reasons why we keep any documentation checked-in. The release workflow isn't something special that needs to be kept in a separate, inaccessible place. At least I can't see a reasons from what you've told. Maybe there are other factors you're not sharing but I can't address those.

I have moved the content of the Trello card to a readme.

oliviertassinari · 2020-12-01T15:58:07Z

lerna.json

@@ -1,5 +1,4 @@
 {
-  "packages": ["packages/*", "docs", "framer"],


Has no effect, useWorkspaces override it.

oliviertassinari · 2020-12-01T16:00:28Z

What are all the changes to the tsconfigs for?

@eps1lon There are a couple of different changes in the tsconfigs. Some are purely about sorting the properties to be in the same order in all the files. I could move them to a "batch". I think that the only important change for the types is around tsconfig.build.composite.json. I can't get the cd packages/material-ui/ && yarn build command to work on my environment. Could you check that it works for you? It would help identify if it's an issue with my env or the dependencies. Thanks! The solution I have found in my env is to remove composite: true. I had to remove it to get the .ts -> .d.ts file generation work.

oliviertassinari · 2020-12-01T16:06:19Z

Could you check that it works for you?

Actually, these reproduction steps aren't accurate. On the next branch, what I can reproduce the error with is this command:

yarn build:codesandbox

Then, once it fails, I can have cd packages/material-ui/ && yarn build fail.

eps1lon · 2020-12-01T19:46:21Z

So can we handle this another time then? It sounds like the tsconfig changes are not blocking any step in the release process. Unless you're doing something difference, hence the request to add documentation.

oliviertassinari · 2020-12-01T19:51:07Z

So can we handle this another time then?

@eps1lon During the last release, it has almost blocked me from releasing (v5.0.0-alpha.17). I had to find the trick (remove composite). Unfortunately it was breaking the CI, so I added it back in 86ec791 on next.

eps1lon · 2020-12-01T19:55:24Z

Could you please describe the steps that are breaking? First you said it was build:codesandbox but that's unrelated to releasing the packages.

If it's only cd ... && yarn * then use yarn workspace ... * instead.

eps1lon · 2020-12-01T20:02:15Z

Unfortunately it was breaking the CI, so I added it back in 86ec791 on next.

Well nobody can help you if you don't ask and silently commit to the repo. The CI is not for certain groups only. It helps everyone so please leverage it instead of skipping it. This can leave the repository in a broken state that nobody is aware of.

oliviertassinari · 2020-12-01T20:20:17Z

Could you please describe the steps that are breaking?

A cleaner reproduction:

Setup

git clone [email protected]:mui-org/material-ui.git foo
cd foo
yarn

Build 1 ✅

cd packages/material-ui/ && yarn build

Build the lab

cd ../packages/material-ui-lab/ && yarn build && cd ../../

Build 2 ❌

cd packages/material-ui/ && yarn build

The CI is not for certain groups only. It helps everyone so please leverage it instead of skipping it. This can leave the repository in a broken state that nobody is aware of.

That wasn't "clean", agree. Hopefully, the change was small enough to be easy to revert.

eps1lon · 2020-12-01T20:35:14Z

Perfect, it's already reproducible with just repeating yarn workspace @material-ui/core build. We clean the build folder but don't tell TypeScript that we changed the build state (i.e. delete tsconfig.build.tsbuildinfo. Will include fix in #23805

Update: Fixed by de34a4d (#23805)

eps1lon · 2020-12-01T21:02:17Z

Should be rebased on next and the tsconfig changes removed.

oliviertassinari added the core Infrastructure work going on behind the scenes label Nov 30, 2020

oliviertassinari force-pushed the lerna branch 2 times, most recently from 9225c33 to 52ad2e8 Compare November 30, 2020 23:47

oliviertassinari marked this pull request as ready for review December 1, 2020 00:10

oliviertassinari requested a review from eps1lon December 1, 2020 00:10

eps1lon reviewed Dec 1, 2020

View reviewed changes

oliviertassinari commented Dec 1, 2020

View reviewed changes

eps1lon mentioned this pull request Dec 1, 2020

[core] Fully clear composite TypeScript project state #23805

Merged

eps1lon closed this in #23805 Dec 1, 2020

eps1lon reopened this Dec 1, 2020

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 1, 2020

oliviertassinari force-pushed the lerna branch from ddb808e to 4e8e697 Compare December 1, 2020 23:14

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 1, 2020

oliviertassinari force-pushed the lerna branch 2 times, most recently from 07b2df8 to 4b8373f Compare December 1, 2020 23:17

oliviertassinari requested a review from eps1lon December 1, 2020 23:32

oliviertassinari mentioned this pull request Dec 2, 2020

[5.0.0-alpha.17] Blank page when using styled-engine-sc #23814

Closed

oliviertassinari force-pushed the lerna branch 2 times, most recently from 6c41c0d to 1b970ab Compare December 2, 2020 16:45

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 2, 2020

[core] Release with lerna

c2ac558

oliviertassinari force-pushed the lerna branch from 1b970ab to c2ac558 Compare December 2, 2020 23:59

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 3, 2020

add docs for release

51cbda0

eps1lon approved these changes Dec 3, 2020

View reviewed changes

oliviertassinari merged commit 6cc38f9 into mui:next Dec 3, 2020

oliviertassinari deleted the lerna branch December 3, 2020 09:44

mbrookes pushed a commit to oliviertassinari/material-ui that referenced this pull request Dec 3, 2020

[core] Use Lerna to publish (mui#23793)

d7e2090

oliviertassinari mentioned this pull request Dec 7, 2020

[core] All packages are published from /build #23886

Merged

oliviertassinari mentioned this pull request Jan 16, 2024

[core] Change package manager to pnpm #36287

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core] Use Lerna to publish #23793

[core] Use Lerna to publish #23793

oliviertassinari commented Nov 30, 2020 •

edited

Loading

mui-pr-bot commented Nov 30, 2020 •

edited

Loading

eps1lon left a comment

eps1lon Dec 1, 2020

oliviertassinari Dec 1, 2020 •

edited

Loading

oliviertassinari Dec 1, 2020 •

edited

Loading

eps1lon Dec 2, 2020

oliviertassinari Dec 2, 2020 •

edited

Loading

eps1lon Dec 2, 2020 •

edited

Loading

eps1lon Dec 2, 2020

oliviertassinari Dec 2, 2020

eps1lon Dec 2, 2020

oliviertassinari Dec 2, 2020

oliviertassinari Dec 1, 2020

oliviertassinari commented Dec 1, 2020 •

edited

Loading

oliviertassinari commented Dec 1, 2020 •

edited

Loading

eps1lon commented Dec 1, 2020

oliviertassinari commented Dec 1, 2020 •

edited

Loading

eps1lon commented Dec 1, 2020

eps1lon commented Dec 1, 2020

oliviertassinari commented Dec 1, 2020 •

edited

Loading

eps1lon commented Dec 1, 2020 •

edited

Loading

eps1lon commented Dec 1, 2020

		"release": "yarn build:release && lerna publish --no-changelog --dist-tag next --contents build",
		"publish:dry-run": "lerna publish --no-changelog --dist-tag next --contents build --no-git-tag-version --no-push --registry=\"http://localhost:4873/\"",

		@@ -1,5 +1,4 @@
		{
		"packages": ["packages/*", "docs", "framer"],

[core] Use Lerna to publish #23793

[core] Use Lerna to publish #23793

Conversation

oliviertassinari commented Nov 30, 2020 • edited Loading

mui-pr-bot commented Nov 30, 2020 • edited Loading

eps1lon left a comment

Choose a reason for hiding this comment

eps1lon Dec 1, 2020

Choose a reason for hiding this comment

oliviertassinari Dec 1, 2020 • edited Loading

Choose a reason for hiding this comment

oliviertassinari Dec 1, 2020 • edited Loading

Choose a reason for hiding this comment

eps1lon Dec 2, 2020

Choose a reason for hiding this comment

oliviertassinari Dec 2, 2020 • edited Loading

Choose a reason for hiding this comment

eps1lon Dec 2, 2020 • edited Loading

Choose a reason for hiding this comment

eps1lon Dec 2, 2020

Choose a reason for hiding this comment

oliviertassinari Dec 2, 2020

Choose a reason for hiding this comment

eps1lon Dec 2, 2020

Choose a reason for hiding this comment

oliviertassinari Dec 2, 2020

Choose a reason for hiding this comment

oliviertassinari Dec 1, 2020

Choose a reason for hiding this comment

oliviertassinari commented Dec 1, 2020 • edited Loading

oliviertassinari commented Dec 1, 2020 • edited Loading

eps1lon commented Dec 1, 2020

oliviertassinari commented Dec 1, 2020 • edited Loading

eps1lon commented Dec 1, 2020

eps1lon commented Dec 1, 2020

oliviertassinari commented Dec 1, 2020 • edited Loading

eps1lon commented Dec 1, 2020 • edited Loading

eps1lon commented Dec 1, 2020

oliviertassinari commented Nov 30, 2020 •

edited

Loading

mui-pr-bot commented Nov 30, 2020 •

edited

Loading

oliviertassinari Dec 1, 2020 •

edited

Loading

oliviertassinari Dec 1, 2020 •

edited

Loading

oliviertassinari Dec 2, 2020 •

edited

Loading

eps1lon Dec 2, 2020 •

edited

Loading

oliviertassinari commented Dec 1, 2020 •

edited

Loading

oliviertassinari commented Dec 1, 2020 •

edited

Loading

oliviertassinari commented Dec 1, 2020 •

edited

Loading

oliviertassinari commented Dec 1, 2020 •

edited

Loading

eps1lon commented Dec 1, 2020 •

edited

Loading