-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Grid] Migrate to emotion #24395
Merged
Merged
[Grid] Migrate to emotion #24395
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
8a19199
init
mnajdova 68021d0
grid
mnajdova c6be491
buildAPI fix support for kebab case classes
mnajdova 4d3f4cb
wip
mnajdova 7016ed7
prettier
mnajdova c2c8f9d
test
mnajdova 118b489
use longhand props
mnajdova 6e03c35
screen size agnostic grid tests
eps1lon 40d664d
sx prop typings
mnajdova 142c0a8
Merge pull request #22 from eps1lon/feat/grid-migrate-to-emotion-test…
mnajdova 961aa8f
sort asc
oliviertassinari 5c8c572
share box sizing style
oliviertassinari 5c2ae96
avoid indirection
oliviertassinari 9730ffc
remove default value {}
oliviertassinari 1785a4a
sort asc
oliviertassinari d1eb86c
styleProps can't be undefined
oliviertassinari 0a361d9
no need to share the component in the state
oliviertassinari edd89ca
apply the same trick as CssBaseline
oliviertassinari 747801f
implemented proposal
mnajdova 6e25d37
Sebastian's review
mnajdova 7da608c
Merge pull request #23 from mnajdova/feat/fix-requirePropFactory
mnajdova a886a9e
prettier
mnajdova bfa61f5
prettier & lint
mnajdova eb4c9e1
reverted requirePropFactory changes
mnajdova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,6 @@ | ||
export default function requirePropFactory(componentNameInError: string): any; | ||
import * as React from 'react'; | ||
|
||
export default function requirePropFactory( | ||
componentNameInError: string, | ||
Component?: React.ComponentType | ||
): any; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got this failing test now https://app.circleci.com/pipelines/github/mui-org/material-ui/35659/workflows/8454c729-bc8f-49ba-8ae5-9fde972ca739/jobs/215603
Also, not sure how smart it is to disable this rule - https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-foreign-prop-types.md
I will revert the changes related to this and open a separte PR on this tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The eslint rule docs links https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types to the why. It's fine in our case. The block is wrapped with the process.env.NODE_ENV === 'production' condition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, anyway will fix it separately to keep this PR clean