[DataTable] Add example in docs for data table #24428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanailH
requested review from
mbrookes,
oliviertassinari,
mnajdova and
eps1lon
Co-authored-by: Olivier Tassinari <[email protected]>
|
The documentation isn't working in dev mode, a tip, look into: |
oliviertassinari
added
the
component: data grid
oliviertassinari
approved these changes
Jan 18, 2021
There was a problem hiding this comment.
It seems to work well https://deploy-preview-24428--material-ui.netlify.app/components/tables/#data-table. I think that we can merge once the pull request for v5 support on Material-UI X is merged and released.
github-actions
bot
added
the
PR: out-of-date
|
@DanailH This effort can be resumed now. |
|
|
github-actions
bot
removed
the
PR: out-of-date
DanailH
commented
Jan 27, 2021
oliviertassinari
approved these changes
Jan 27, 2021
eps1lon
approved these changes
Jan 27, 2021
xs9627
added a commit
to xs9627/material-ui
that referenced
this pull request
Jan 27, 2021
* next: (34 commits) [Tab] Migrate to emotion (mui#24651) [TextField] Migrate Input component to emotion (mui#24638) [ImageList] Migrate ImageListItemBar to emotion (mui#24632) [CircularProgress] Migrate to emotion (mui#24622) [DataTable] Add example in docs for data table (mui#24428) [Card] Migrate CardActionArea to emotion (mui#24636) [core] Fix `next` using stale pages (mui#24635) [List] Migrate ListItemIcon to emotion (mui#24630) [ClickAwayListener] Fix `children` and `onClickAway` types (mui#24565) [docs] Include in docs directive to silence `eslint` erroneous warning (mui#24644) [Fab] Migrate to emotion (mui#24618) [TextField] Migrate FilledInput to emotion (mui#24634) [Card] Migrate CardHeader to emotion (mui#24626) [Card] Migrate CardMedia to emotion (mui#24625) [ImageList] Migrate ImageListItem to emotion (mui#24619) [website] Add vision block (mui#24603) [docs] Add sorting section (mui#24637) [TextField] Prepare removal of labelWidth prop (mui#24595) [Dialog] Migrate DialogTitle to emotion (mui#24623) [ImageList] Migrate to emotion (mui#24615) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-24428--material-ui.netlify.app/components/tables/#data-table
For now, this will remain as a draft. Once the new version of
DataGridthat supports v5 is released I'll convert it to a normal PR and we can merge it.This is part of mui/mui-x#441 and mui/mui-x#855.