Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pickers] Fix role attribute #24621

Merged
merged 10 commits into from
Jan 26, 2021
Merged

[Pickers] Fix role attribute #24621

merged 10 commits into from
Jan 26, 2021

Conversation

EkaterinaMozheiko
Copy link
Contributor

@EkaterinaMozheiko EkaterinaMozheiko commented Jan 25, 2021 •
edited
Loading

Closes #24171

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 25, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against dc35dda

@oliviertassinari oliviertassinari changed the title [DateRangePickerDay][PickersCalendar]: Add role attribute [DateRangePicker] Fix role attribute Jan 25, 2021
@oliviertassinari oliviertassinari added accessibility a11y component: date range picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! and removed component: date range picker This is the name of the generic UI component, not the React module! labels Jan 25, 2021
@oliviertassinari oliviertassinari changed the title [DateRangePicker] Fix role attribute [pickers] Fix role attribute Jan 25, 2021
@github-actions github-actions bot mentioned this pull request Jan 25, 2021
Closed
eps1lon
eps1lon requested changes Jan 26, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test illustrating the issue so that we understand the fix in the future.

@eps1lon eps1lon added the PR: needs test The pull request can't be merged label Jan 26, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 26, 2021 •
edited
Loading

@eps1lon The test was https://deploy-preview-24621--material-ui.netlify.app/components/date-picker/ not returning errors in https://validator.w3.org/. We can assert the DOM structure automatically, OK, I'm on it.

@eps1lon
Copy link
Member

eps1lon commented Jan 26, 2021

Why can't this test be automated?

@oliviertassinari
Copy link
Member

@eps1lon We can, I was sharing the thought process, I'm on it.

@eps1lon
Copy link
Member

eps1lon commented Jan 26, 2021

I'm asking because this seems pretty straightforward to do here with the tools available. Ideally we'd have a way more comprehensive test suite. But since we haven't we might as well start small.

@oliviertassinari oliviertassinari force-pushed the add-role-attribute-to-datepickers branch from 0fb2691 to 4c130ff Compare January 26, 2021 12:26
eps1lon
eps1lon approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Not so sure if it's important to have grid > row and not just grid row but failing if this changes may remind us to manually verify if this change is ok.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 26, 2021 •
edited
Loading

Not so sure if it's important to have grid > row and not just grid row.

@eps1lon Agree, I wondered about this. I couldn't find the information online (I haven't looked deep enough), I went with what seemed to put the most constraints in place.

@oliviertassinari oliviertassinari removed the PR: needs test The pull request can't be merged label Jan 26, 2021
@oliviertassinari oliviertassinari merged commit ef5259b into mui:next Jan 26, 2021
@oliviertassinari
Copy link
Member

@EkaterinaMozheiko Thanks for having a look at the issue

@oliviertassinari oliviertassinari changed the title [pickers] Fix role attribute [Pickers] Fix role attribute Jan 28, 2021
@oliviertassinari oliviertassinari mentioned this pull request Feb 11, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
accessibility a11y component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DatePicker] w3c validator issues
4 participants
@EkaterinaMozheiko @mui-pr-bot @oliviertassinari @eps1lon