Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Skeleton] Migrate to emotion #24652

Merged
merged 19 commits into from
Feb 11, 2021
Merged

[Skeleton] Migrate to emotion #24652

merged 19 commits into from
Feb 11, 2021

Conversation

kodai3
Copy link
Contributor

@kodai3 kodai3 commented Jan 27, 2021 •
edited
Loading

This PR migrates the Skelton component to the new emotion format as a part of #24405.

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 27, 2021 •
edited
Loading

@material-ui/core: parsed: +0.27% , gzip: +0.33%
@material-ui/lab: parsed: +0.28% , gzip: +0.31%

Details of bundle changes

Generated by 🚫 dangerJS against 1f4c8e3

@github-actions github-actions bot mentioned this pull request Jan 27, 2021
Closed
@oliviertassinari oliviertassinari changed the title [Skelton] migrate to emotion [Skeleton] Migrate to emotion Jan 27, 2021
@oliviertassinari oliviertassinari added the component: skeleton This is the name of the generic UI component, not the React module! label Jan 27, 2021
@oliviertassinari oliviertassinari mentioned this pull request Jan 27, 2021
Closed
mnajdova
mnajdova previously requested changes Jan 28, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's convert the styles the css syntax, otherwise, styled-components won't work

packages/material-ui/src/Skeleton/Skeleton.js Outdated Show resolved Hide resolved
@kodai3
Copy link
Contributor Author

kodai3 commented Feb 2, 2021

I have fixed where it was reviewed + α. Now running yarn test:unit locally passes but, ci/circleci: test_unit-1 fails.

@oliviertassinari oliviertassinari merged commit 5aba908 into mui:next Feb 11, 2021
@Sandeep06Dev Sandeep06Dev mentioned this pull request Feb 11, 2021
Merged
1 task
@oliviertassinari oliviertassinari mentioned this pull request Feb 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: skeleton This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kodai3 @mui-pr-bot @oliviertassinari @mnajdova