Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[styled-engine] Fix GlobalStyles not to throw when no theme is available #24671

Merged
merged 3 commits into from
Jan 28, 2021

Conversation

mnajdova
Copy link
Member

Fixes the following issue found in #24489 (comment)

image

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 28, 2021

Details of bundle changes

Generated by 🚫 dangerJS against a52d7e7

@eps1lon eps1lon added the package: styled-engine Specific to @mui/styled-engine label Jan 28, 2021
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me unless the visual regression tests fail.

@mnajdova
Copy link
Member Author

Looks good to me unless the visual regression tests fail.

No visual regressions found, will merge should be pretty safe change :)

@mnajdova mnajdova merged commit 2c42921 into mui:next Jan 28, 2021
natac13 pushed a commit to natac13/material-ui that referenced this pull request Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: styled-engine Specific to @mui/styled-engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants