Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Follow similar demo pattern for date and time pickers #24739

Merged
merged 2 commits into from
Feb 2, 2021
Merged

[docs] Follow similar demo pattern for date and time pickers #24739

merged 2 commits into from
Feb 2, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Feb 1, 2021 •
edited
Loading

Preview: http://deploy-preview-24739--material-ui.netlify.app/components/time-picker/ (modelled after /components/date-picker

  • basic example for TimePicker no longer includes ampm usage
    I guess in general we want to ensure that the very first/"basic" demo displays the JSX inline.
    Though I would not enforce this explicitly but implicitly by keeping the demo small (as few chars as possible).
  • basic example for TimePicker uses no value as a default (following the other 3 picker basic demos)
  • use default TextField variant (outlined) (was standard)

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Feb 1, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Feb 1, 2021 •
edited
Loading

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%

Details of bundle changes

Generated by 🚫 dangerJS against 818a360

@oliviertassinari oliviertassinari added the component: time picker This is the name of the generic UI component, not the React module! label Feb 2, 2021
@eps1lon eps1lon merged commit 44884aa into mui:next Feb 2, 2021
@eps1lon eps1lon deleted the docs/pickers/normalize branch February 2, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: time picker This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari