Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Align more with the v5 recommended approach #24798

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

Tejaswiangotu123
Copy link
Contributor

@Tejaswiangotu123 Tejaswiangotu123 commented Feb 6, 2021

Edit by @oliviertassinari

#24496 removes the inconsistency of the value accepted by the Typography color prop. The changes update the examples. These examples are important as they serve as a baseline for developers learning the library.

In the future, we will need to:

  • Migrate all the codebase from color="textSecondary" to color="text.secondary"
  • Add a depreciation for the older API along the lifecycle of v5 stable
  • Consider providing a codemod for making the migration
  • Agree on when to use the flat props over the sx. So far, we have added the flat props because of the strong demand from developers. However, we haven't yet agreed on a standard.

@mui-pr-bot
Copy link

mui-pr-bot commented Feb 6, 2021

Details of bundle changes

Generated by 🚫 dangerJS against 20202ca

@mbrookes
Copy link
Member

mbrookes commented Feb 6, 2021

@Tejaswiangotu123 What's the reason for this proposed change?

@mbrookes mbrookes added the status: waiting for author Issue with insufficient information label Feb 6, 2021
@oliviertassinari oliviertassinari self-assigned this Feb 6, 2021
@oliviertassinari oliviertassinari changed the title Update App.js [examples] Align more with the v5 recommended approach Feb 6, 2021
@oliviertassinari oliviertassinari changed the base branch from master to next February 6, 2021 21:19
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation and removed status: waiting for author Issue with insufficient information labels Feb 6, 2021
@oliviertassinari oliviertassinari force-pushed the patch-1 branch 2 times, most recently from e8e4192 to d86e8d8 Compare February 6, 2021 21:24
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbrookes considering the author tried to improve the examples on v4, moving with a diff similar to what we use in v5, I have continued the spirit of the effort to align the example more with what we recommend so far.

@oliviertassinari oliviertassinari removed their assignment Feb 6, 2021
@mbrookes
Copy link
Member

mbrookes commented Feb 6, 2021

CircleCI just keeps getting worse...

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 6, 2021

The CI has been out of service, for a week. I had a first call this week with a sales representative at CircleCI. We have another call Monday with @eps1lon for sizing a solution. We suspect they throttle us (significantly), we use more than the monthly free credits.

@mbrookes
Copy link
Member

mbrookes commented Feb 7, 2021

CircleCI just keeps getting worse...

The CI has been out of service, for a week.

Nope, worse:

image
image

image
image

@oliviertassinari
Copy link
Member

@mbrookes Well, yeah. The issue has started to manifest about 4 weeks ago. It's has been increasingly worse since then. Last week, I had opened https://discuss.circleci.com/t/runs-are-2-times-slower-during-the-weekend-why/38967/3.

@oliviertassinari oliviertassinari merged commit 7187a6d into mui:next Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants