-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Align more with the v5 recommended approach #24798
Conversation
@Tejaswiangotu123 What's the reason for this proposed change? |
e8e4192
to
d86e8d8
Compare
d86e8d8
to
20202ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbrookes considering the author tried to improve the examples on v4, moving with a diff similar to what we use in v5, I have continued the spirit of the effort to align the example more with what we recommend so far.
CircleCI just keeps getting worse... |
The CI has been out of service, for a week. I had a first call this week with a sales representative at CircleCI. We have another call Monday with @eps1lon for sizing a solution. We suspect they throttle us (significantly), we use more than the monthly free credits. |
@mbrookes Well, yeah. The issue has started to manifest about 4 weeks ago. It's has been increasingly worse since then. Last week, I had opened https://discuss.circleci.com/t/runs-are-2-times-slower-during-the-weekend-why/38967/3. |
Edit by @oliviertassinari
#24496 removes the inconsistency of the value accepted by the Typography
color
prop. The changes update the examples. These examples are important as they serve as a baseline for developers learning the library.In the future, we will need to:
color="textSecondary"
tocolor="text.secondary"
sx
. So far, we have added the flat props because of the strong demand from developers. However, we haven't yet agreed on a standard.