[docs] Breakdown Chip demos into smaller ones #25750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
approved these changes
Apr 13, 2021
|
@oliviertassinari We delete old demo files? I remember that it was commented that they should also move to |
|
I think that we can remove the old demos and ignore the visual regression. I believe the new demos are enough. |
|
Cleaner, well done 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The promised.
Improvements in the
Chipcomponent display demos.Currently, the demos are being wrapped by a
Stackcomponent, this should change if the chips texts are longer or if you want to add more chips to the demos. The above so that in mobile it can be seen well.I await comments so that we continue to iterate the new page proposal.
One chunk of #22484.
Preview: https://deploy-preview-25750--material-ui.netlify.app/components/chips/