Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Timeline] Migrate TimelineContent to emotion #25781

Merged
merged 18 commits into from
Apr 16, 2021
Merged

[Timeline] Migrate TimelineContent to emotion #25781

merged 18 commits into from
Apr 16, 2021

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Apr 15, 2021 •
edited by oliviertassinari
Loading

One of #24405

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 15, 2021 •
edited
Loading

Details of bundle changes

@material-ui/lab: parsed: +0.13% , gzip: +0.10%

Generated by 🚫 dangerJS against ecbd75b

mnajdova
mnajdova reviewed Apr 15, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review :)

packages/material-ui-lab/src/TimelineContent/TimelineContent.d.ts Show resolved Hide resolved
packages/material-ui-lab/src/TimelineContent/TimelineContent.js Outdated Show resolved Hide resolved
packages/material-ui-lab/src/TimelineContent/TimelineContent.js Show resolved Hide resolved
packages/material-ui-lab/src/TimelineContent/TimelineContent.js Outdated Show resolved Hide resolved
packages/material-ui-lab/src/TimelineContent/TimelineContent.js Show resolved Hide resolved
packages/material-ui-lab/src/TimelineContent/timelineContentClasses.js Outdated Show resolved Hide resolved
test/utils/describeConformance.js Outdated Show resolved Hide resolved
@mnajdova mnajdova added the component: timeline This is the name of the generic UI component, not the React module! label Apr 15, 2021
@mnajdova mnajdova changed the title [TimelineContent] migrate to emotion [Timeline] Migrate TimelineContent to emotion Apr 15, 2021
@oliviertassinari oliviertassinari mentioned this pull request Apr 15, 2021
Closed
@siriwatknp
Copy link
Member Author

siriwatknp commented Apr 16, 2021 •
edited
Loading

@oliviertassinari @mnajdova I cannot find a way to fix this, need your helps. (works fine locally)

Trigger CI again fixed the error. 😊

image

mnajdova
mnajdova approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @siriwatknp 👍

@mnajdova mnajdova merged commit c9c69b5 into mui:next Apr 16, 2021
@vicasas vicasas mentioned this pull request Apr 17, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: timeline This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siriwatknp @mui-pr-bot @oliviertassinari @mnajdova