Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add example with switch dark/light mode #25823

Merged
merged 2 commits into from
Apr 19, 2021
Merged

[docs] Add example with switch dark/light mode #25823

merged 2 commits into from
Apr 19, 2021

Conversation

Vikram710
Copy link
Contributor

@Vikram710 Vikram710 commented Apr 18, 2021 •
edited by oliviertassinari
Loading

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 18, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against cd34ea4

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Apr 18, 2021
@oliviertassinari
Copy link
Member

@vicasas Could you check the preview. Does it solve your pain?

@vicasas
Copy link
Member

vicasas commented Apr 18, 2021 •
edited
Loading

@oliviertassinari Yes, it looks great. I see it is alone for v4. It would be nice to use it with context instead of useState

@vicasas
Copy link
Member

vicasas commented Apr 18, 2021 •
edited
Loading

I see it is alone for v4. It would be nice to use it with context instead of useState

Woow! I just saw that the code was updated

mnajdova
mnajdova approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @Vikram710

@mnajdova mnajdova merged commit 76c5e34 into mui:next Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Add example with switch dark/light mode
5 participants
@Vikram710 @mui-pr-bot @oliviertassinari @vicasas @mnajdova