Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix ad duplication #25831

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 18, 2021

Closes #25828. I have seen this happen multiple times in the past but could never figure out how to reliably reproduce the bug, until today.

Preview: https://deploy-preview-25831--material-ui.netlify.app/components/alert/

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels Apr 18, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 18, 2021

No bundle size changes

Generated by 🚫 dangerJS against e4a9707

@oliviertassinari
Copy link
Member Author

@DanielJDupont Could you confirm that the issue is solved on the preview link? I can't spot it anymore.

@DanielJDupont
Copy link

I believe the issue is resolved, I tried throttling the connection and playing around with the Chrome network tools, I am not able to reproduce the bug anymore on the preview.

@oliviertassinari
Copy link
Member Author

Great, thanks

@oliviertassinari oliviertassinari merged commit cf6d544 into mui:next Apr 19, 2021
@oliviertassinari oliviertassinari deleted the docs-fix-ads branch April 19, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Ads repeating with broken styling
3 participants