[docs] Fix /production-error crash #25839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
eps1lon
commented
Apr 19, 2021
| const [rating, setRating] = React.useState(); | ||
| const [comment, setComment] = React.useState(''); | ||
| const [commentOpen, setCommentOpen] = React.useState(false); | ||
| const [snackbarOpen, setSnackbarOpen] = React.useState(false); | ||
| const [snackbarMessage, setSnackbarMessage] = React.useState(false); | ||
| const inputRef = React.useRef(); | ||
| const pageList = flattenPages(pages); | ||
| const currentPageNum = findIndex(pageList, (page) => page.pathname === activePage?.pathname); | ||
| const currentPage = pageList[currentPageNum]; |
There was a problem hiding this comment.
If activePage was not null then currentPage === activePage i.e. currentPage was redundant.
eps1lon
commented
Apr 19, 2021
| * If a page should be excluded from this order, set `order: false`. | ||
| * You want to set `ordered: false` if you don't want the page to appear in an ordered list e.g. for previous/next page navigation. | ||
| */ | ||
| ordered?: boolean; |
There was a problem hiding this comment.
The wording is a bit rough. displayNav also works considering the disableDrawer wording. Maybe just keep the original word but keep the description?
oliviertassinari
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash in /production-error/ (current
next): https://deploy-preview-25839--material-ui.netlify.app/production-error/The previous logic for creating the prev/next page navigation relied on the current order of pages. However, one could imagine that we later extend the pages to
Now
/a/new/pagewould not be considered the next page after/an/existing/page. With this PR users will be able to navigate from/an/existing/pageto/a/new/pagewith thenextbutton.The change required for this seems quite big but should be easier to follow and more robust against various positions of
activePage. For example,activePagebeing the last entry inpageswould lead to a crash. We didn't encounter this crash because of the current order ofpages.