Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] setProps from createPickerRender should set props on the rendered element #26405

Merged
merged 1 commit into from
May 24, 2021
Merged

[test] setProps from createPickerRender should set props on the rendered element #26405

merged 1 commit into from
May 24, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented May 21, 2021

Previously setProps from createPickerRender would set props on the provider. This was suprising to me and probably not what we want generally.

@eps1lon eps1lon added the test label May 21, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented May 21, 2021 •
edited
Loading

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 2c4c6f5

@eps1lon eps1lon marked this pull request as ready for review May 21, 2021 14:33
oliviertassinari
oliviertassinari approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did the same in https://github.com/mui-org/material-ui-x/blob/c29da5dfdd31e924b9c0c9a245c39784d8225f4e/test/utils/index.tsx#L10

@eps1lon eps1lon merged commit 7b24c6e into mui:next May 24, 2021
@eps1lon eps1lon deleted the test/createRender-wrapper-setProps branch May 24, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari