-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Add Vite.js example #28241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the config is quite small I don't think we want to include this example. The problem is that once it's included we need to maintain it for which we currently don't have the bandwidth. Though we definitely want to revisit this when we have a dedicated role for this problem space.
@eps1lon I've applied to the Developer Advocate role, so if I'm hired I would be able to own this and the other examples, freeing some bandwidth for you all :) |
Thanks for the work. Closing this until we have the bandwidth to support these types of examples. Looking forward to your application 👍🏻 |
@goncalovf We are primarily looking in the US/Canada for this role (and a bit the UK), thanks for the interest thought.
@mui-org/core I think that it's worth discussing more. Keeping #21377 open and closing this PR doesn't seem compatible. From what I understand, the root ESM issue with vite is fixed. What bandwidth do we need to keep to support the examples? How important are the examples? Based on the assumption that: examples are key to minimizing churn of new users, that next.js supports dozens of examples with the same size team like us, that #21377 has a number of upvotes, and that vite is relatively popular: https://npm-stat.com/charts.html?package=next,vite,snowpack. +1 to reopen this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, sorry for the delay :)
Shouldn't this example have used From the looks of it |
Fix #21377
The example I added is based on the React template provided by Vite.js
I did not add aliases to the vite.config.js (as suggested here, here and here as workarounds to the base issues described in #21377 and in the issue in Vite.js) because the issue should be resolved by Vite.js.
CodeSandbox with this example:
TODO:
Question: Should I make a typescript example?