[test] Document where the value for SwitchBase#value comes from #28638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
test
component: switch
eps1lon
commented
Sep 27, 2021
| const { getByRole } = render( | ||
| <SwitchBase icon="unchecked" checkedIcon="checked" type="checkbox" value="off" />, |
There was a problem hiding this comment.
That's just encoding double negation i.e. if the input is not submitted, then it's not off. I just assume that nobody would want to write it that way so let's use a more reasonable use-case.
eps1lon
commented
Sep 27, 2021
| const { getByRole } = render( | ||
| <SwitchBase icon="unchecked" checkedIcon="checked" type="checkbox" />, | ||
| ); | ||
|
|
||
| expect(getByRole('checkbox')).not.to.have.property('value', ''); | ||
| // https://html.spec.whatwg.org/multipage/input.html#dom-input-value-default-on | ||
| expect(getByRole('checkbox')).to.have.property('value', 'on'); |
There was a problem hiding this comment.
negative assertions are good when we don't care about what a value is. But here we actually do care because ' ' should fail as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick follow-up to #28423 that adds a bit of clarity to why
valueis the way it is.