Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codemod] Add MenuItem v.1.0.0 transform for primaryText property #28640

Merged

Conversation

dmitry-yudakov
Copy link
Contributor

@dmitry-yudakov dmitry-yudakov commented Sep 27, 2021

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 27, 2021

No bundle size changes

Generated by 🚫 dangerJS against 44c748a

@siriwatknp
Copy link
Member

siriwatknp commented Sep 28, 2021

@dmitry-yudakov looks good. This is awesome for first contribution 👏.

  • What do you think about moving this mod to v5.0.0 folder?
  • Can you add one test case for function, eg. this case
    <MenuItem primaryText={getText('something')} />

@dmitry-yudakov
Copy link
Contributor Author

@siriwatknp Sure, I added the function test case.

I don't mind moving it to v5.0.0 though from reading the docs I had an impression that codemod works for migrations like v0->v1, v3->v4, v4->v5, not v0->v5. As this primaryText property was in v0 does it make sense to put it to v5.0.0?

In my case - migrating from v0 to v5 - I didn't expect v5.0.0 transforms to be of much use for me.

@siriwatknp
Copy link
Member

As this primaryText property was in v0

You are right. I have checked that MenuItem does not have primaryText anymore (in v5), so it make sense to put this mod in v1.0.0

@siriwatknp siriwatknp merged commit 3562f1f into mui:master Sep 29, 2021
@zannager zannager added the package: codemod Specific to @mui/codemod label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: codemod Specific to @mui/codemod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants