Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codemod] Update the imports in jss-to-styled to match the new package names #28667

Merged
merged 1 commit into from
Sep 28, 2021
Merged

[codemod] Update the imports in jss-to-styled to match the new package names #28667

merged 1 commit into from
Sep 28, 2021

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Sep 28, 2021 •
edited
Loading

Changes done in the generated files:

-import { styled } from '@material-ui/core/styles';
+import { styled } from '@mui/styled/styles';

The codemod could be run after the codemod for the rename of the packages, so it could create wrong paths.

Fixes #28666

@mnajdova mnajdova requested a review from siriwatknp September 28, 2021 13:18
@mnajdova mnajdova changed the title [codemod] Update the generated imports in jss-to-styled codemod to match the new package names [codemod] Update the imports in jss-to-styled to match the new package names Sep 28, 2021
siriwatknp
siriwatknp approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 28, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 4fab8bc

@mnajdova mnajdova merged commit f491abc into mui:master Sep 28, 2021
@zannager zannager added the package: codemod Specific to @mui/codemod label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
package: codemod Specific to @mui/codemod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[codemod] Handle @mui/material/styles in jss-to-styled
4 participants
@mnajdova @mui-pr-bot @siriwatknp @zannager