[Tooltip] Allow overriding internal components and their props #28692
Conversation
michaldudak
added
component: tooltip
|
@material-ui/core: parsed: +0.11% , gzip: +0.17% |
| @@ -225,12 +225,15 @@ function composeEventHandler(handler, eventHandler) { | |||
| }; | |||
| } | |||
|
|
|||
| // TODO (v6) Remove PopperComponent, PopperProps, TransitionComponent and TransitionProps. | |||
There was a problem hiding this comment.
I would recommend this todo convention,
| // TODO (v6) Remove PopperComponent, PopperProps, TransitionComponent and TransitionProps. | |
| // TODO v6: Remove PopperComponent, PopperProps, TransitionComponent and TransitionProps. |
It reduces the chance to forget something. There are already instances for v5 and v6 in the codebase.
| @@ -225,12 +225,15 @@ function composeEventHandler(handler, eventHandler) { | |||
| }; | |||
| } | |||
|
|
|||
| // TODO (v6) Remove PopperComponent, PopperProps, TransitionComponent and TransitionProps. | |||
There was a problem hiding this comment.
I would recommend this todo convention,
| // TODO (v6) Remove PopperComponent, PopperProps, TransitionComponent and TransitionProps. | |
| // TODO v6: Remove PopperComponent, PopperProps, TransitionComponent and TransitionProps. |
It reduces the chance to forget something. There are already instances for v5 and v6 in the codebase.
| @@ -1092,6 +1092,96 @@ describe('<Tooltip />', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('prop: components', () => { | |||
There was a problem hiding this comment.
Do we need to test it? For instance, we didn't really test classes before.
There was a problem hiding this comment.
components prop is normally tested in describeConformanceUnstyled test suite, but since we don't have an unstyled Tooltip yet, I added the test here directly. It can be removed when we have an unstyled Tooltip.
First discussed in #28679 (comment)
Adds
componentsandcomponentPropsprops to the Tooltip component.For slots that were customizable before (Transition, Popper), the new props (
components.Transition,components.Popper) take precedence over the old ones (TransitionComponent,PopperComponent).In the case of props,
componentsProps.popperare merged withPopperPropsandcomponentsProps.transitionare merged withTransitionProps. When there are conflicts,componentsProps' values win.